Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] fix returned variable type in keypoint_pck_accuracy #2479

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

Ben-Louis
Copy link
Collaborator

@Ben-Louis Ben-Louis commented Jun 25, 2023

Motivation

If the keypoint accuracy is 0, the function keypoint_pck_accuracy will return an integer 0 instead of a float, leading to the bug reported in #2372

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

❗ No coverage uploaded for pull request base (dev-1.x@ed79b17). Click here to learn what that means.
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 97377fd differs from pull request most recent head 5d45646. Consider uploading reports for the commit 5d45646 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             dev-1.x    #2479   +/-   ##
==========================================
  Coverage           ?   80.77%           
==========================================
  Files              ?      251           
  Lines              ?    15216           
  Branches           ?     2636           
==========================================
  Hits               ?    12291           
  Misses             ?     2258           
  Partials           ?      667           
Flag Coverage Δ
unittests 80.77% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmpose/evaluation/functional/keypoint_eval.py 93.10% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Tau-J Tau-J merged commit a0ca076 into open-mmlab:dev-1.x Jun 26, 2023
8 of 9 checks passed
@Ben-Louis Ben-Louis deleted the fix-keypoint-eval branch July 10, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants