Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix magnitude_range in RandAug #249

Merged
merged 4 commits into from
May 12, 2021

Conversation

LXXXXR
Copy link
Contributor

@LXXXXR LXXXXR commented May 12, 2021

Hi,
In this pull request, we allow users to set magnitude range as (max_val, min_val) or (min_val, max_val). Pls kindly take a look. Thank you.

@LXXXXR LXXXXR requested review from ycxioooong and mzr1996 May 12, 2021 02:51
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #249 (bdf2060) into master (9e93fea) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head bdf2060 differs from pull request most recent head f7c9ded. Consider uploading reports for the commit f7c9ded to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
+ Coverage   72.82%   72.85%   +0.02%     
==========================================
  Files          88       88              
  Lines        4453     4457       +4     
  Branches      782      784       +2     
==========================================
+ Hits         3243     3247       +4     
  Misses       1109     1109              
  Partials      101      101              
Flag Coverage Δ
unittests 72.85% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/datasets/pipelines/auto_augment.py 78.44% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e93fea...f7c9ded. Read the comment docs.

mmcls/datasets/pipelines/auto_augment.py Outdated Show resolved Hide resolved
@LXXXXR LXXXXR requested a review from mzr1996 May 12, 2021 06:18
Copy link
Contributor

@ycxioooong ycxioooong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LXXXXR LXXXXR changed the title [Fix] Add increasing in solarize and posterize [Fix] Fix magnitude_range in RandAug May 12, 2021
Copy link
Member

@mzr1996 mzr1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@ycxioooong ycxioooong merged commit 8c90a87 into open-mmlab:master May 12, 2021
@LXXXXR LXXXXR deleted the add_reverse branch May 27, 2021 12:46
mzr1996 pushed a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
* add increasing in solarize and posterize

* fix linting

* Revert "add increasing in solarize and posterize"

This reverts commit 128af36.

* revise according to comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants