Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor]: Inherits mmcv registry #252

Merged
merged 1 commit into from
May 14, 2021

Conversation

ZwwWayne
Copy link
Contributor

This PR modifies the registry of models. It changes to inherit from MMCV registry, thus in the future OpenMMLab repos like MMDet and MMSeg could directly use the backbones supported in MMCls.

Related PR: open-mmlab/mmdetection#5059, open-mmlab/mmsegmentation#515

@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #252 (437e286) into master (8c90a87) will increase coverage by 0.04%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
+ Coverage   72.83%   72.88%   +0.04%     
==========================================
  Files          88       88              
  Lines        4455     4451       -4     
  Branches      782      780       -2     
==========================================
- Hits         3245     3244       -1     
+ Misses       1109     1107       -2     
+ Partials      101      100       -1     
Flag Coverage Δ
unittests 72.88% <93.33%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/models/builder.py 94.44% <93.33%> (+12.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c90a87...437e286. Read the comment docs.

Copy link
Contributor

@ycxioooong ycxioooong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. LGTM.

@ycxioooong ycxioooong merged commit 5ee0876 into open-mmlab:master May 14, 2021
mzr1996 pushed a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants