Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge code generation changes to main #295

Merged

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Mar 7, 2024

Brings all code generation changes to the main branch

@lmolkova lmolkova requested review from a team March 7, 2024 21:17
Copy link

@trisch-me trisch-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm assuming these are commits from already approved and merged PRs

semantic-conventions/README.md Outdated Show resolved Hide resolved
semantic-conventions/README.md Outdated Show resolved Hide resolved
semantic-conventions/README.md Outdated Show resolved Hide resolved
semantic-conventions/README.md Outdated Show resolved Hide resolved
semantic-conventions/README.md Outdated Show resolved Hide resolved
@joaopgrassi
Copy link
Member

joaopgrassi commented Mar 15, 2024

lgtm assuming these are commits from already approved and merged PRs

Same 👍

If there's something not working or that needs ironing out, I'm sure we can do it soon after a release, so not much risk here :)

Co-authored-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com>
@lmolkova lmolkova merged commit 157bb4b into open-telemetry:main Mar 15, 2024
3 checks passed
@jack-berg
Copy link
Member

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants