-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand GenAI project to cover instrumentation libraries #2326
base: main
Are you sure you want to change the base?
Conversation
Thank you for bringing this topic up @lmolkova . From Langtrace, myself and my colleague, Ali are happy to contribute/maintain/approve the channges. |
Tagging more people in the community who might be interested to work on instrumentation libraries @AmanAgarwal041 @cartermp @codefromthecrypt @langchain4j @trentm |
@lmolkova happy to assist here! I think my co-founder @galkleinman would also want to participate |
@lmolkova More than happy to help here! |
|
||
Alternating weekly meetings to accommodate different time zones: | ||
|
||
- Week 1: Wednesdays at 10 AM PST |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to move this to 9AM PST? It would be a bit more easier to partecipate from central europe timezones :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I updated the doc - will start a poll to find more times. BTW we have another meeting at 8am Thu CET, would that one work for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the meeting time change (for rest of world) when the clocks move back an hour in November?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe time stays the same in the timezone it's specified.
Lines 130 to 131 in ad757c7
> All meeting hours between 2pm and 1am UTC are in Pacific Time (PT), with Daylight Saving Time. | |
> All meeting hours between 2am and 1pm UTC in UTC+8, without Daylight Saving Time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very happy to see this taking shape!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple org/scope related questions which are possibly just because I am new to how things are structured. Please forgive if they are misplaced.
projects/gen-ai.md
Outdated
|
||
**Engineers:** | ||
- Python | ||
- maintainers/approvers: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in otel terminology we have both maintainer and approver defined, are we saying in these repos there is no difference? Cool with me, just curious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't usually separate maintainers and approvers in project templates.
For this project I believe we'll work in the following repos:
- central repo for issues/discussions/maybe prototypes/artifacts, but probably no implementation code -
opentelmetry-genai
(new).- Maintainers/approvers listed here will be the same for this repo
- semantic-conventions and corresponding semconv-llm-approvers which are codeowners for GenAI files. I think we need to expand this group and include more people who've been active and consistent contributors to semantic conventions.
- opentelemetry-js-contrib maintainers/approvers for JS will become component owners, I hope @trentm would keep me honest here
- opentelemtery-python-contrib - similar component-ownership model
- new repos - it seems that we would need to start python work in a separate repo and if it's the case, we'll need to decide. I updated the list and added existing Otel Python/JS maintainers to maintainers for potential new repos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see this in motion, Few nits as to keep vendor neutrality from this proposal. Me and @AmanAgarwal041 are happy to contribute instrumentations from https://github.com/openlit/openlit aswell
Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
Co-authored-by: patcher9 <patcher99@dokulabs.com> Co-authored-by: Emily S <emily.s@elastic.co>
1d8067b
to
7bd84b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used to maintain js and python for zipkin and currently dusting off my skills, reviewing and maintaining these languages again.
If you need another approver who will pull changes local, test them, verify against current practice, etc before clicking ✔️ , feel free to use me. There's a lot of work to do, and I suspect this will help keep wheels in APAC moving.
projects/gen-ai.md
Outdated
- @drewby | ||
- @karthikscale3 | ||
- @nirga | ||
- *looking for existing OTel JS approvers/maintainers for general JS & OTel feedback* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- *looking for existing OTel JS approvers/maintainers for general JS & OTel feedback* | |
- @codefromthecrypt | |
- *looking for existing OTel JS approvers/maintainers for general JS & OTel feedback* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be great to have you!
There are requirements for approvers/maintainers status in the community
which boils down to the history of contributions.
The list in this PR is an initial set and is expected to evolve based on the existing process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was worth a shot!
Meanwhile, I'll open an issue on the community project because there is a chicken/egg condition which is a special case to new projects looking to acquire new people. For example, it discusses "the codebase" whereas no code exists yet. I'll take that offline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment tbh here aswell
#2326 (comment)
- @drewby | ||
- @karthikscale3 | ||
- @nirga | ||
- @xrmx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- @xrmx | |
- @xrmx | |
- @codefromthecrypt |
- @drewby | ||
- @karthikscale3 | ||
- @nirga | ||
- @xrmx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would preferably want to be more than a contributor as this would affect our SDK aswell like others
- @xrmx | |
- @xrmx | |
- @patcher9 | |
- @AmanAgarwal041 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some requirements around approver/maintainer status in the community
https://github.com/open-telemetry/community/blob/main/guides/contributor/membership.md
which boils down to the history of previous contributions.
A good place to start would be to first request to join OTel org: https://github.com/open-telemetry/community/issues/new?assignees=&labels=area%2Fgithub-membership&projects=&template=membership.md&title=REQUEST%3A+New+membership+for+%3Cyour-GH-handle%3E
and after making some contributions ask to become an approver.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I ask previous contributions to OTel for everyone in the Codeowners/approvers list here (Not taking a shot at anyone or personal, Just curious)? Just wanna get a grasp on how much would we need to be since @AmanAgarwal041 already has a JS PR for OpenAI Instrumentation in review much like the Python one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patcher9 I think you are adding yourself to the maintainer list where currently there's me and Leighton that are already maintainers for the Python SIG.
AFAIK people listed as component / code owners are people that already contributed to semconv-llm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patcher9 maybe focus on the approvers part as "maintainer" is a higher bar. I'm not sure when this doc needs to land, but someone could propose you or aman as a community member now. You might already be a member before this doc merges. Many people have only been members 6 months or less.
Once a member, you can choose to try to make the case that some approvers have not worked on code (instrumentation) and not this semver doc or visa versa. Also, the case about the code contribution already underway, as well points about this project aiming to widen the community since it has such a large new scope, and obviously you folks already have experience in it. I'd vote for you, though I don't think approver status is a vote thing at this point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah approvers is what I had in mind my bad (Maintainers I understand why we cant be assigned). This to an extent does seem very closed source tbh even for a new project (we can say its an extension but if we look at it the work has already been started for the JS OpenAI SDK so not sure what the criteria is again) and alsp considering how the language was changed.
Im fine with this just that I don't completely agree (Feel free to resolve)
projects/gen-ai.md
Outdated
- approvers/codeowners: | ||
- @drewby | ||
- @karthikscale3 | ||
- @nirga |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- @nirga | |
- @nirga | |
- @patcher9 | |
- @AmanAgarwal041 |
|
||
Alternating weekly meetings to accommodate different time zones: | ||
|
||
- Week 1: Wednesdays at 10 AM PST |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the meeting time change (for rest of world) when the clocks move back an hour in November?
- @trentm | ||
- *looking for existing OTel JS maintainers for general JS & OTel feedback* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lmolkova Not sure if it was clear, but I am an OTel JS maintainer.
- @trentm | ||
- *looking for existing OTel JS maintainers for general JS & OTel feedback* | ||
- TBD | ||
- **initial** JS and Python GenAI component/code owners (based on LLM Semantic Convention project involvement): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Component/code owner isn't a formal concept in the opentelemetry project. In opentelemetry-java-contrib
, the bar is fairly low:
- must be a member of the OpenTelemetry organization (required for github automation)
- must be responsive to issues / PRs
- must express interest in being a code owner
Not sure what the criteria is for other *-contrib
repositories. It looks like opentelemetry-collector-contrib
has some documentation on the role, but it boils down to "the person is interested and the existing code owners / maintainers approve".
Can / should we broaden this group of code owners to the group of people that meet this loose criteria (member of Otel org, ready to respond to issues / PRs, interested)? In my experience with contrib repos, the problem has been underparticipation, not over participation.
@@ -34,6 +35,8 @@ words: | |||
- jemmic | |||
- keptn | |||
- kubecon | |||
- Langfuse | |||
- Langtrace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may need to add LangSmith here as well
- @alizenhom (JS & Python) | ||
- @codefromthecrypt (JS & Python) | ||
- @galkleinman (JS & Python) | ||
- @gyliu513 (JS & Python) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lmolkova I want to nominate myself to join OTEL community as a member, but I only did some PR reviews and attend some LLM Semantic Convention meetings, what do you think of counting in the effort that we contribute to https://github.com/traceloop/openllmetry/tree/main/packages as well? All of the instrumentation code are based on OpenTelemetry, and I think this may become the code base for the python instrumentation code, it will be great if we can count in those efforts for someone to apply to be a member of otel community, what do you think? Thanks!
Based on the discussions in LLM semconv group, we'd like to suggest expanding the scope of the group to cover instrumentation libraries.
The long-term goal of the project is:
We intend to add instrumentations one-by-one and limit features to those documented in semantic conventions. Instrumentations will evolve along with semconv, but may provide additional hooks or opt-in features allowing to customize them to specific vendor needs.
We're going to request
opentelemetry-genai
repo for the coordination/project management, but may request additional repos later to host WIP gen-ai instrumentation libraries when using existing contrib repos is problematic. with the long-term goal to contribute them upstream or merge to contrib once possible.We're looking for engineers to work on instrumentation libraries, especially in JavaScript and existing JS-contrib approvers/maintainers to help with code review, best practices and general OTel.
/cc @alolita @tedsuo @trask @nirga @drewby @karthikscale3 @lzchen