Ending "Paused" span for a fragment. #591
Open
+41
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(I've been meaning to add this before but forgot) I haven't changed the tests for this because I wanted to wait for a review of the idea not to change them needlessly, as I haven't dug into our unit tests. That's why it doesn't pass checks. |
Fix tests to match expected output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may be a simple fix for the #590 issue I just submitted. However I don't know the reasoning for the current way, so I don't know if it creates new problems.
Currently
onFragmentPausedandonFragmentStoppedadd events to the same span, which is ended inonFragmentStopped. I propose to end an active span inonFragmentPausedand create a new one inonFragmentStopped. With those changesPausedfor About activity is a parent ofPausedfor the last fragment and analogously withStopped(so 2 traces with 2 spans each) . Unrelated spans get their own traces in between and after.In addition to fixing #590 this is consistent with how in Activity Lifecycle Instrumentation
PausedandStoppedare separate spans.