Skip to content
This repository has been archived by the owner on Oct 29, 2021. It is now read-only.

Update to collector v0.28.0 #48

Closed
jpkrohling opened this issue Jun 9, 2021 · 2 comments · Fixed by #49
Closed

Update to collector v0.28.0 #48

jpkrohling opened this issue Jun 9, 2021 · 2 comments · Fixed by #49
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jpkrohling
Copy link
Member

Similar to #38 but for v0.28.0.
@jpkrohling jpkrohling added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jun 9, 2021
@ttomsu
Copy link

ttomsu commented Jun 11, 2021 •
edited
Loading

My app is unable to build this line in main.go:

app, err := service.New(service.Parameters{BuildInfo: info, Factories: factories})

It seems service.Parameters is no longer there (now AppSettings). This appears to be where it was changed.

@jpkrohling
Copy link
Member Author

The builder version is currently tracking the collector's. So, the builder's 0.27 should be used with the collector 0.27. After 1.0, we should be able to give better assurances. If you need to build 0.28, feel free to send a PR to update the builder to address the collector's changes. Otherwise, I should have some time to work on this in a couple of weeks.

@fangyi-zhou fangyi-zhou mentioned this issue Jun 16, 2021
Merged
jpkrohling pushed a commit that referenced this issue Jun 24, 2021
@fangyi-zhou
Update to Collector v0.28.0 (#49)
16563b6 
* Update to Collector v0.28.0

Closes #48

Addresses the breaking API change in
open-telemetry/opentelemetry-collector#3163,
besides the usual version number changes.

Signed-off-by: Fangyi Zhou <me@fangyi.io>

* Use `go mod tidy` instead of `go mod download`

It appears that this magically resolves the go.mod file issue.
https://stackoverflow.com/questions/67203641/missing-go-sum-entry-for-module-providing-package-package-name

Signed-off-by: Fangyi Zhou <me@fangyi.io>
@jpkrohling jpkrohling mentioned this issue Jun 24, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to Collector v0.28.0
2 participants
@jpkrohling @ttomsu