-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
datadogreceiver produces incorrect telemetry.sdk.language #29459
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Thanks for filing @povilasv, and for including all of the references! Agreed that this is a bug. I don't have much context with the |
I don't think the So I don't think it makes sense to ask Datadog folks to change some header |
…ET (#29460) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Looks like DataDog's library uses ".NET" as value instead of "dotnet" in their instrumentation: See: https://github.com/DataDog/dd-trace-dotnet/blob/ecb5d5949f6c29dbe99a451c7a3574013cfeb1bd/tracer/src/Datadog.Trace/AgentHttpHeaderNames.cs#L76 So we need to remap ".NET" to "dotnet" to follow OTEL semantic conventions. **Link to tracking Issue:** #29459 **Testing:** <Describe what testing was performed and which tests were added.> - added unit test **Documentation:** <Describe the documentation added.>
Component(s)
receiver/datadog
What happened?
Description
Looks like DataDog's library uses ".NET" as value instead of "dotnet" in their instrumentation:
See: https://github.com/DataDog/dd-trace-dotnet/blob/ecb5d5949f6c29dbe99a451c7a3574013cfeb1bd/tracer/src/Datadog.Trace/AgentHttpHeaderNames.cs#L76
So we need to remap ".NET" to "dotnet" to follow OTEL semantic conventions.
I've also doublechecked other variables, and they seem to map to semantic conventions correctly -> https://opentelemetry.io/docs/specs/semconv/resource/#telemetry-sdk
The only other odd language is javascript. DD uses "javascript" in their instrumentation -> https://github.com/search?q=repo%3ADataDog%2Fdd-trace-js%20Datadog-Meta-Lang&type=code
But we don't seem to have equivalent in semantic conventions?
Steps to Reproduce
Expected Result
Actual Result
Collector version
v0.89.0
Environment information
Environment
OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")
OpenTelemetry Collector configuration
No response
Log output
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: