Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/stanza] Standardize structure of operators #32058

Closed
35 tasks done
djaglowski opened this issue Apr 1, 2024 · 1 comment
Closed
35 tasks done

[pkg/stanza] Standardize structure of operators #32058

djaglowski opened this issue Apr 1, 2024 · 1 comment
Assignees

Comments

@djaglowski
Copy link
Member

djaglowski commented Apr 1, 2024

Component(s)

pkg/stanza

Describe the issue you're reporting

This is a tracking issue for a set of cleanup operations which would be helpful in the long run. I've noticed while working on #31664 many operators have nonstandard file naming and structure. When attempting to make changes across the codebase, these variations make it more difficult to establish confidence that we're doing things the same in each operator. I'd like to enforce the following patterns in each operator:

  1. Operator structs and file names should use the class e.g. Input/input.go, Output/output.go, Parser/parser.go, Transformer/transformer.go.
  2. Separate code into config.go and <class>.go.

TODO

  • input/file
  • input/generate
  • input/journald
  • input/namedpipe
  • input/stdin
  • input/syslog
  • input/tcp
  • input/udp
  • input/windows
  • output/drop
  • output/file
  • output/stdout
  • parser/csv
  • parser/json
  • parser/jsonarray
  • parser/keyvalue
  • parser/regex
  • parser/scope
  • parser/severity
  • parser/syslog
  • parser/time
  • parser/trace
  • parser/uri
  • transformer/add
  • transformer/assignkeys
  • transformer/copy
  • transformer/filter
  • transformer/flatten
  • transformer/move
  • transformer/noop
  • transformer/recombine
  • transformer/remove
  • transformer/retain
  • transformer/router
  • transformer/unquote
@djaglowski djaglowski added the help wanted Extra attention is needed label Apr 1, 2024
djaglowski added a commit that referenced this issue Apr 1, 2024
djaglowski added a commit that referenced this issue Apr 2, 2024
@djaglowski djaglowski self-assigned this Apr 2, 2024
@djaglowski djaglowski removed the help wanted Extra attention is needed label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant