Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/hostmetrics] replace unmaintained library github.com/leoluk/perflib_exporter #33652

Closed
andrzej-stencel opened this issue Jun 19, 2024 · 3 comments
Closed

[receiver/hostmetrics] replace unmaintained library github.com/leoluk/perflib_exporter #33652

andrzej-stencel opened this issue Jun 19, 2024 · 3 comments
Assignees
@andrzej-stencel
Labels
needs triage New item requiring triage receiver/hostmetrics

Comments

@andrzej-stencel
Copy link
Member

andrzej-stencel commented Jun 19, 2024 •
edited
Loading

Component(s)

receiver/hostmetrics

Describe the issue you're reporting

The repository https://github.com/leoluk/perflib_exporter has been archived since July 2023 and has a note that the perflib package is now maintained under https://github.com/prometheus-community/windows_exporter.

The perflib library has been integrated into windows_exporter and development continues there. Both library users of perflib as well as perflib_exporter users should migrate to windows_exporter, which is actively maintained and has well-defined metrics.

Let's switch from https://pkg.go.dev/github.com/leoluk/perflib_exporter/perflib to https://pkg.go.dev/github.com/prometheus-community/windows_exporter/pkg/perflib.
@andrzej-stencel andrzej-stencel added the needs triage New item requiring triage label Jun 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@andrzej-stencel andrzej-stencel self-assigned this Jun 19, 2024
@andrzej-stencel andrzej-stencel mentioned this issue Jun 19, 2024
Merged
@andrzej-stencel
Copy link
Member Author

Should be resolved by:

andrzej-stencel added a commit to andrzej-stencel/opentelemetry-collector-contrib that referenced this issue Jun 19, 2024
@andrzej-stencel
[chore][receiver/hostmetrics] replace unmaintained library `github.co…
fe6c384 
…m/leoluk/perflib_exporter`

Fixes open-telemetry#33652
This was referenced Jun 19, 2024
Closed
Closed
Closed
Closed
andrzej-stencel added a commit that referenced this issue Jun 20, 2024
@andrzej-stencel
[chore][receiver/hostmetrics] replace unmaintained library `github.co…
3ed11a2 
…m/leoluk/perflib_exporter` (#33653)

**Description:**

This replaces `perflib` package from the unmaintained library
https://github.com/leoluk/perflib_exporter with `perflib` package from
https://github.com/prometheus-community/windows_exporter.

The added benefit of this update is a potential collector startup time
improvement, as there's initialization code removed:
prometheus-community/windows_exporter@11218a9.

I wonder if this change should be mentioned in the Changelog? 🤔

**Link to tracking Issue:** <Issue number if applicable>

-
#33652

**Testing:**

No changes.

**Documentation:**

No changes.
@crobert-1
Copy link
Member

Closing as resolved by #33653, thanks @andrzej-stencel!

This was referenced Jun 20, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrzej-stencel andrzej-stencel

Labels
needs triage New item requiring triage receiver/hostmetrics
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrzej-stencel @crobert-1