Move the OTel and OC metrics test helper utilities #13428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OpenCensus metrics test utils
jmacd
requested review from
dmitryax,
dashpole,
jsuereth and
punya
as code owners
dashpole
approved these changes
Aug 19, 2022
|
Reviewers, please help unblock statsd receiver improvements with this minor refactoring requested in the review here: #12951 |
dashpole
added
the
ready to merge
|
@codeboten I know you suggested this change, but I would encourage you to no longer suggest using of OC metrics, we should ask everyone to use pdata for tests and other places. |
|
I specifically moved the old OC test helpers without touching them, to help with eliminating them from the code base. This wasn't requested by @codeboten, was @mx-psi here #12951 (comment) because I had extended the OTel-specific test helpers in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Requested in #12951 (comment).
Link to tracking Issue: Part of #5742.
Testing: New test helpers are added to validate attributes (was an existing TODO) and the exponential histogram data point.
Documentation: None.