Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/sumologic]: update configuration format #23061

Merged

Conversation

sumo-drosiek
Copy link
Member

@sumo-drosiek sumo-drosiek commented Jun 5, 2023

Description:

Link to tracking Issue:

Part of #23059

Testing: N/A

Documentation: Readme changed

@sumo-drosiek
Copy link
Member Author

cc: @astencel-sumo

@andrzej-stencel andrzej-stencel added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 5, 2023
@sumo-drosiek sumo-drosiek force-pushed the drosiek-sumoexporter-description branch from bba26ff to 5e36452 Compare June 6, 2023 08:58
@sumo-drosiek sumo-drosiek changed the title [exporter/sumologic]: update configuration format [exporter/sumologic]: deprecating options which are going to be removed Jun 6, 2023
@sumo-drosiek sumo-drosiek force-pushed the drosiek-sumoexporter-description branch from da7ca00 to 17981a3 Compare June 6, 2023 11:29
@sumo-drosiek
Copy link
Member Author

I can split this PR on two parts if needed:

  • changing configuration format in readme
  • changes deprecation

@sumo-drosiek sumo-drosiek force-pushed the drosiek-sumoexporter-description branch from 17981a3 to 9e7a3c0 Compare June 6, 2023 12:23
@andrzej-stencel
Copy link
Member

Yes, I think it's better to create two separate PRs for these two changes.

@andrzej-stencel andrzej-stencel removed the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 6, 2023
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
@sumo-drosiek sumo-drosiek force-pushed the drosiek-sumoexporter-description branch from 9e7a3c0 to 21beae6 Compare June 6, 2023 13:39
@sumo-drosiek sumo-drosiek changed the title [exporter/sumologic]: deprecating options which are going to be removed [exporter/sumologic]: update configuration format Jun 6, 2023
@sumo-drosiek
Copy link
Member Author

Yes, I think it's better to create two separate PRs for these two changes.

Restoring to previous state then

@andrzej-stencel andrzej-stencel added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 6, 2023
@andrzej-stencel
Copy link
Member

Re-adding the Skip Changelog label then 😄

Copy link
Member

@andrzej-stencel andrzej-stencel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is just a README formatting change in preparation for future deprecations 👍

@codeboten
Copy link
Contributor

Restarting integration test, the failure may have been addressed in #23187

@dmitryax dmitryax merged commit 9a93eed into open-telemetry:main Jun 7, 2023
@github-actions github-actions bot added this to the next release milestone Jun 7, 2023
@sumo-drosiek sumo-drosiek deleted the drosiek-sumoexporter-description branch June 12, 2023 06:03
Caleb-Hurshman pushed a commit to observIQ/opentelemetry-collector-contrib that referenced this pull request Jul 6, 2023
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/sumologic Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants