[exporter/datasetexporter]: Fix NPE exception when attribute contains nil #27663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Follow up PR: #27683 |
atoulme
approved these changes
Oct 16, 2023
JaredTan95
pushed a commit
to openinsight-proj/opentelemetry-collector-contrib
that referenced
this pull request
Oct 18, 2023
… nil (open-telemetry#27663) **Description:** Nil is valid value for the attributes in events, spans, resources, and scopes. Lets do not crash when it appears. **Link to tracking Issue:** open-telemetry#27648 **Testing:** I have added unit tests to verify the fix. **Documentation:** <Describe the documentation added.>
sigilioso
pushed a commit
to carlossscastro/opentelemetry-collector-contrib
that referenced
this pull request
Oct 27, 2023
… nil (open-telemetry#27663) **Description:** Nil is valid value for the attributes in events, spans, resources, and scopes. Lets do not crash when it appears. **Link to tracking Issue:** open-telemetry#27648 **Testing:** I have added unit tests to verify the fix. **Documentation:** <Describe the documentation added.>
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
… nil (open-telemetry#27663) **Description:** Nil is valid value for the attributes in events, spans, resources, and scopes. Lets do not crash when it appears. **Link to tracking Issue:** open-telemetry#27648 **Testing:** I have added unit tests to verify the fix. **Documentation:** <Describe the documentation added.>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Nil is valid value for the attributes in events, spans, resources, and scopes. Lets do not crash when it appears.
Link to tracking Issue: #27648
Testing: I have added unit tests to verify the fix.
Documentation:
Closes #27648