[servicegraphconnector] Add flush interval config #27879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpkrohling
reviewed
Oct 20, 2023
|
|
||
| // Metrics are not immediately flushed | ||
| assert.Len(t, metricsExporter.md, 0) | ||
| time.Sleep(time.Second * 5) |
There was a problem hiding this comment.
Can you do a smaller flush interval for this test and use assert. Eventually here? Otherwise, the test will take at least 5 seconds to run. Seen individually, it's not a huge problem, but on the bigger context, it might cause our CI to take longer and longer :-/
jpkrohling
approved these changes
Oct 24, 2023
jpkrohling
changed the title
sigilioso
pushed a commit
to carlossscastro/opentelemetry-collector-contrib
that referenced
this pull request
Oct 27, 2023
**Description:** Add a config option to periodically flush metrics, instead of flushing on every push. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#27679 **Testing:** <Describe what testing was performed and which tests were added.> Added tests that verify metrics are flushed asynchronously **Documentation:** <Describe the documentation added.> Documentation added to `config.go` --------- Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de>
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
**Description:** Add a config option to periodically flush metrics, instead of flushing on every push. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#27679 **Testing:** <Describe what testing was performed and which tests were added.> Added tests that verify metrics are flushed asynchronously **Documentation:** <Describe the documentation added.> Documentation added to `config.go` --------- Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de>
bogdandrutu
pushed a commit
that referenced
this pull request
Jan 10, 2024
…opy configuration README (#29919) **Documentation:** <Describe the documentation added.> #27879 recently added a new configuration option to the `servicegraph` components called `metrics_flush_interval`. I noticed this wasn't documented for either component, and the `connector/servicegraph` README doesn't include a configuration section. Since the connector is just a wrapper of the processor at this point, I cleaned up the processor's configuration section and copied it to the connector, adding an entry for the new `metrics_flush_interval` option.
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jan 10, 2024
…opy configuration README (open-telemetry#29919) **Documentation:** <Describe the documentation added.> open-telemetry#27879 recently added a new configuration option to the `servicegraph` components called `metrics_flush_interval`. I noticed this wasn't documented for either component, and the `connector/servicegraph` README doesn't include a configuration section. Since the connector is just a wrapper of the processor at this point, I cleaned up the processor's configuration section and copied it to the connector, adding an entry for the new `metrics_flush_interval` option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add a config option to periodically flush metrics, instead of flushing on every push.
Link to tracking Issue: #27679
Testing: Added tests that verify metrics are flushed asynchronously
Documentation: Documentation added to
config.go