Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/zipkin] use confighttp.DefaultHTTPClientSettings #29931

Merged

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Dec 16, 2023

Description:
Modernize the logic of validation by moving to config Validate from the Start function
Use the HTTPClientDefaultSettings defaults when setting the config.

Link to tracking Issue:
#6641

Testing:
Updated tests.

exporter/zipkinexporter/config.go Show resolved Hide resolved
exporter/zipkinexporter/config_test.go Outdated Show resolved Hide resolved
@bogdandrutu bogdandrutu merged commit cd8cef0 into open-telemetry:main Dec 19, 2023
84 of 85 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 19, 2023
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Jan 10, 2024
…metry#29931)

**Description:**
Modernize the logic of validation by moving to config Validate from the
Start function
Use the HTTPClientDefaultSettings defaults when setting the config.

**Link to tracking Issue:**
open-telemetry#6641

**Testing:**
Updated tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants