Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/ottl] Fix bug where IsBool wasn't usable #30151

Merged

Conversation

TylerHelmuth
Copy link
Member

Description:
Found a bug where the BoolGetter and BoolLikeGetter types were not included in the function parser's switch statement. This meant OTTL didn't know how to interpret that parameter type which mean IsBool is not actually usable.

I missed this while reviewing #27900

Link to tracking Issue:
Found while working on #28642 - issues like these are why these e2e tests will be useful.

Testing:
Will add the e2e tests as part of #28642

@TylerHelmuth TylerHelmuth merged commit d4bfdf2 into open-telemetry:main Dec 21, 2023
85 checks passed
@TylerHelmuth TylerHelmuth deleted the ottl-add-bool-getters-to-switch branch December 21, 2023 15:43
@github-actions github-actions bot added this to the next release milestone Dec 21, 2023
TylerHelmuth added a commit that referenced this pull request Jan 8, 2024
**Description:** 
Adds e2e tests for OTTL functionality and all `ottlfuncs` functions.

Includes the bug fix from
#30151

**Link to tracking Issue:** <Issue number if applicable>
Closes
#28642

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>
Updated contributing doc
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Jan 10, 2024
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Jan 10, 2024
**Description:** 
Adds e2e tests for OTTL functionality and all `ottlfuncs` functions.

Includes the bug fix from
open-telemetry#30151

**Link to tracking Issue:** <Issue number if applicable>
Closes
open-telemetry#28642

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>
Updated contributing doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants