chore: fix handling of metrics with created suffix #30808
Conversation
I added a test case for counters, will add one for summaries and histograms too. |
Okay, so double checked there are positive tests for _created when it's actually _created timestamp being parsed and used for all of the three. We have also a test case for a counter where _created is not the actual created timestamp and is being left as is. Should I add a test case for the latter for summaries and histograms too? |
I think we'd better cover them all. |
|
Discussed at the prometheus wg meeting. There are already tests for the _created suffix that work correctly. |
|
Pipeline failure for a different component unrelated to my changes. |
dashpole
added
bug
) Description: As discussed in the OTEL Prometheus working group, to fix this case we check If the metricfamily (which we get from the metadata) name + _created == the series name match. Then we treat it as created timestamp. Link to tracking Issue: open-telemetry#30309 Testing: Reproduced based on the details provided in the issue, added a test case covering the case. Documentation: --------- Co-authored-by: David Ashpole <dashpole@google.com>
jmichalek132
deleted the
jm-fix-handling-of-metrics-with-created-suffix-2
branch
Description:
As discussed in the OTEL Prometheus working group, to fix this case we check If the metricfamily (which we get from the metadata) name + _created == the series name match. Then we treat it as created timestamp.
Link to tracking Issue: #30309
Testing: Reproduced based on the details provided in the issue, added a test case covering the case.
Documentation: