Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/azureeventhubreceiver]Implemented receiver to support traces #33583

Merged
merged 10 commits into from
Aug 8, 2024
Merged

[receiver/azureeventhubreceiver]Implemented receiver to support traces #33583

merged 10 commits into from
Aug 8, 2024

Conversation

deepan10
Copy link
Contributor

Description: Implemented azureeventhubreceiver to support traces

Link to tracking Issue:

Testing:

Documentation: Added information in to README.md

@deepan10 deepan10 requested a review from atoulme as a code owner June 14, 2024 21:59
@deepan10 deepan10 requested a review from a team June 14, 2024 21:59
@github-actions github-actions bot requested a review from cparkins June 14, 2024 21:59
nslaughter
nslaughter suggested changes Jun 16, 2024
View reviewed changes
Copy link
Contributor

@nslaughter nslaughter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the effort deepan10. I think it will be worth the investment for you to expand on a couple of ideas coming up in this PR with an issue called something like "Support Application Insights traces." The addition of more telemetry is highlighting the importance of being systematic about handling multiple data models, and I think interested parties could collaborate on the direction (including where to land which pieces of the logic) better in that venue.

.chloggen/azureeventhub-trace-receiver.yaml Outdated Show resolved Hide resolved
receiver/azureeventhubreceiver/azureresourcetraces_unmarshaler.go Outdated Show resolved Hide resolved
receiver/azureeventhubreceiver/azureresourcetraces_unmarshaler.go Outdated Show resolved Hide resolved
receiver/azureeventhubreceiver/README.md Outdated Show resolved Hide resolved
receiver/azureeventhubreceiver/azureresourcetraces_unmarshaler.go Outdated Show resolved Hide resolved
receiver/azureeventhubreceiver/azureresourcetraces_unmarshaler.go Outdated Show resolved Hide resolved
receiver/azureeventhubreceiver/azureresourcetraces_unmarshaler.go Outdated Show resolved Hide resolved
receiver/azureeventhubreceiver/azureresourcetraces_unmarshaler.go Outdated Show resolved Hide resolved
@deepan10 deepan10 force-pushed the azureeventhub-trace-receiver branch from 88fc0a5 to 07c3f8e Compare July 6, 2024 11:22
@deepan10 deepan10 requested a review from nslaughter July 6, 2024 11:23
cparkins
cparkins approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@cparkins cparkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes requested appear to have been made. Nice work! Thanks for the comments @nslaughter.

@deepan10 deepan10 force-pushed the azureeventhub-trace-receiver branch from c8ab6a1 to 5838799 Compare July 9, 2024 10:32
@cparkins
Copy link
Contributor

@atoulme Any chance you can look at this for approval?

@deepan10 deepan10 force-pushed the azureeventhub-trace-receiver branch from 9cf3485 to 0ae5a2d Compare July 22, 2024 06:12
@deepan10
Copy link
Contributor Author

Hello @cparkins & @atoulme & @nslaughter
I just did a rebase and no pressure, just want to check anything pending from my end to update?

@deepan10 deepan10 requested a review from atoulme July 22, 2024 20:35
@deepan10 deepan10 force-pushed the azureeventhub-trace-receiver branch 3 times, most recently from 759d6cb to 55ebced Compare July 29, 2024 15:49
cparkins
cparkins approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@cparkins cparkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me. One slight typo that may get caught on the build.

@deepan10 deepan10 force-pushed the azureeventhub-trace-receiver branch from 4e4724c to b5d5c1a Compare July 29, 2024 18:43
@atoulme
Copy link
Contributor

atoulme commented Jul 29, 2024

@nslaughter please review as well

@atoulme atoulme added the ready to merge Code review completed; ready to merge by maintainers label Aug 1, 2024
@atoulme
Copy link
Contributor

atoulme commented Aug 1, 2024

Marking ready to merge - if @nslaughter has no objections by next week, we should get this in

@github-actions github-actions bot mentioned this pull request Aug 6, 2024
Closed
@mx-psi
Copy link
Member

mx-psi commented Aug 8, 2024

Marking ready to merge - if @nslaughter has no objections by next week, we should get this in

One week since this message so I am merging!

@mx-psi mx-psi merged commit 10954c2 into open-telemetry:main Aug 8, 2024
161 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 8, 2024
f7o pushed a commit to f7o/opentelemetry-collector-contrib that referenced this pull request Sep 12, 2024
@deepan10 @f7o
[receiver/azureeventhubreceiver]Implemented receiver to support traces (
4a38917 
open-telemetry#33583)

**Description:** Implemented `azureeventhubreceiver` to support traces
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

**Link to tracking Issue:** <Issue number if applicable>

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** Added information in to `README.md`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoulme atoulme atoulme approved these changes

@cparkins cparkins cparkins approved these changes

@mx-psi mx-psi Awaiting requested review from mx-psi

@codeboten codeboten Awaiting requested review from codeboten

@nslaughter nslaughter Awaiting requested review from nslaughter

Assignees

@mx-psi mx-psi

Labels
cmd/telemetrygen telemetrygen command pkg/translator/azure ready to merge Code review completed; ready to merge by maintainers receiver/azureeventhub
Projects
None yet
Milestone
v0.107.0
Development

Successfully merging this pull request may close these issues.
5 participants
@deepan10 @cparkins @atoulme @mx-psi @nslaughter