[chore] Remove unused internal code #33690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, it looks like this file is what actually includes each component as a required import in the top-level |
|
Relevant PRs and issues: I'm wondering if this functionality as a whole is now duplicated by https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/cmd/otelcontribcol. |
codeboten
approved these changes
Jun 21, 2024
martin-majlis-s1
pushed a commit
to scalyr/opentelemetry-collector-contrib
that referenced
this pull request
Jun 24, 2024
This file appears to be no longer used. Since it's in an `internal` directory it's not exposed publicly, so I don't believe it needs a changelog. For context, I believe its original use was to be consumed by `cmd/configschema`, which has since been [deleted](open-telemetry#33384). I believe we simply missed this file in the removal process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This file appears to be no longer used. Since it's in an
internaldirectory it's not exposed publicly, so I don't believe it needs a changelog.For context, I believe its original use was to be consumed by
cmd/configschema, which has since been deleted. I believe we simply missed this file in the removal process.