Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extensions/observer/cfgardenobserver] Implement cfgardenobserver #34513

Open
wants to merge 63 commits into
base: main
Choose a base branch
from

Conversation

tomasmota
Copy link
Contributor

@tomasmota tomasmota commented Aug 8, 2024

Description:
First Component PR: #33727
This is the second PR for adding the cfgardenobserver, with the first suggested implementation. There are definitely some decisions made that require feedback, such as adding the CloudFoundry application labels to the Endpoint labels, and the decision to use the Container EndpointType at all.

Link to tracking Issue: #33618

Testing: Unit testing of config and extension

Documentation: Updated readme with new configuration and endpoints

@crobert-1
Copy link
Member

Generated code is out of date, please run "make generate" and commit the changes in this PR.

Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just nits.

I haven't gotten a chance to look through tests yet, I wanted to get a review out sooner rather than later. Hope it's helpful 👍

extension/observer/cfgardenobserver/README.md Outdated Show resolved Hide resolved
extension/observer/cfgardenobserver/config.go Outdated Show resolved Hide resolved
extension/observer/cfgardenobserver/config.go Outdated Show resolved Hide resolved
extension/observer/cfgardenobserver/config.go Outdated Show resolved Hide resolved
extension/observer/cfgardenobserver/README.md Outdated Show resolved Hide resolved
extension/observer/cfgardenobserver/extension.go Outdated Show resolved Hide resolved
extension/observer/cfgardenobserver/extension.go Outdated Show resolved Hide resolved
extension/observer/cfgardenobserver/extension.go Outdated Show resolved Hide resolved
extension/observer/cfgardenobserver/extension.go Outdated Show resolved Hide resolved
extension/observer/cfgardenobserver/extension.go Outdated Show resolved Hide resolved
@tomasmota
Copy link
Contributor Author

tomasmota commented Aug 14, 2024

Mostly just nits.

I haven't gotten a chance to look through tests yet, I wanted to get a review out sooner rather than later. Hope it's helpful 👍

I appreciate that, think I have addressed all the issues.

Regarding the context in the struct, I'd like to know if you think what I did (just keeping a channel) is ok, or if I might be missing some need for a context.

@crobert-1
Copy link
Member

Failing unit test is unrelated to this change, I've filed #35007.

@tomasmota tomasmota requested a review from a team as a code owner September 19, 2024 11:21
@tomasmota
Copy link
Contributor Author

hey @crobert-1 there is this single prometheus compliance test that keeps failing for more than a week now and I have no clue why. I have tried checking if it was something with dependencies but no luck. Do you have any idea what it could be?

@crobert-1
Copy link
Member

hey @crobert-1 there is this single prometheus compliance test that keeps failing for more than a week now and I have no clue why. I have tried checking if it was something with dependencies but no luck. Do you have any idea what it could be?

Hey @tomasmota, sorry about that. It's frequency of #35119, unrelated to your changes 👍

@crobert-1
Copy link
Member

It looks like some imports are the wrong version again, but I'm adding ready to merge as it should be good once that's fixed. 👍

@crobert-1 crobert-1 added the ready to merge Code review completed; ready to merge by maintainers label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/otelcontribcol otelcontribcol command extension/observer ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants