Create pkg/datadog module #35067
Merged
Create pkg/datadog module #35067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cmd/otelcontribcol
github-actions
bot
requested review from
ankitpatel96,
liustanley,
mackjmr,
mx-psi and
songy23
dineshg13
changed the title
mx-psi
reviewed
Sep 9, 2024
songy23
reviewed
Sep 9, 2024
|
Can you fix the merge conflict? |
songy23
reviewed
Sep 10, 2024
Co-authored-by: Yang Song <songy23@users.noreply.github.com>
mx-psi
reviewed
Sep 11, 2024
pkg/datadog/config/config.go
Outdated
Comment on lines
107
to
110
| // AddWarning appends to warnings in the configuration. | ||
| func (c *Config) AddWarning(warning error) { | ||
| c.warnings = append(c.warnings, warning) | ||
| } |
There was a problem hiding this comment.
Do we need to make this method public? I want to keep as much of this 'hack' to log warnings private
pkg/datadog/config/host.go
Outdated
| // SourceTimeout is the timeout to fetch from each provider - for example AWS IMDS. | ||
| // If unset, or set to zero duration, there will be no timeout applied. | ||
| // Default is no timeout. | ||
| SourceTimeout time.Duration `mapstructure:"source_timeout"` |
There was a problem hiding this comment.
We are making this public, can we still keep it private somehow? If not, I would like to
- Document this in our examples
- Add a release note
- Make sure this is properly designed and validated so users can't misuse it
There was a problem hiding this comment.
Made it private with set & getter methods
|
Needs |
|
Still need to fix the mod versions: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/10818431257/job/30014098376?pr=35067 |
|
@songy23 fixed. |
songy23
approved these changes
Sep 11, 2024
mx-psi
reviewed
Sep 12, 2024
mx-psi
approved these changes
Sep 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The PR creates
pkg/datadogpackage with configuration for DD Exporter and DD connector.The PR currently retains tests in
exporter/datadogexporter&connector/datadogconnector. These will be remove along with the configuration in exporter & connector.