Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/doris] Second PR (with logs Implementation) of New component: Doris Exporter #35150

Merged
merged 3 commits into from
Sep 16, 2024
Merged

[exporter/doris] Second PR (with logs Implementation) of New component: Doris Exporter #35150

merged 3 commits into from
Sep 16, 2024

Conversation

joker-star-l
Copy link
Contributor

Description:

Second PR of New component: Doris Exporter. Implementation of logs.

Link to tracking Issue: #33479

Testing:

Tested via unit test.

Documentation:

No additional documentation.

@joker-star-l joker-star-l requested a review from a team September 12, 2024 04:06
atoulme
atoulme approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still a bit ugly but the ugly bits are in the test code. That said I am now in the territory of nits and it should not block this code from going in.

@atoulme atoulme added the ready to merge Code review completed; ready to merge by maintainers label Sep 13, 2024
@bogdandrutu bogdandrutu merged commit 1057f72 into open-telemetry:main Sep 16, 2024
162 of 163 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoulme atoulme atoulme approved these changes

Assignees

@MovieStoreGuy MovieStoreGuy

Labels
exporter/doris ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Milestone
next release
Development

Successfully merging this pull request may close these issues.
4 participants
@joker-star-l @atoulme @bogdandrutu @MovieStoreGuy