Skip to content

Commit

Permalink
Nit cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
Paulo Janotti committed Jul 11, 2019
1 parent e4c19de commit 53789c0
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion exporter/zipkinexporter/zipkin_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import (
"bytes"
"encoding/json"
"fmt"
"github.com/open-telemetry/opentelemetry-service/config/configmodels"
"io"
"io/ioutil"
"net"
Expand All @@ -32,6 +31,7 @@ import (
zipkinmodel "github.com/openzipkin/zipkin-go/model"
zipkinreporter "github.com/openzipkin/zipkin-go/reporter"

"github.com/open-telemetry/opentelemetry-service/config/configmodels"
"github.com/open-telemetry/opentelemetry-service/internal/config/viperutils"
"github.com/open-telemetry/opentelemetry-service/internal/testutils"
"github.com/open-telemetry/opentelemetry-service/processor/multiconsumer"
Expand Down
4 changes: 2 additions & 2 deletions observability/observabilitytest/observabilitytest.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,15 @@ func SetupRecordedMetricsTest() (doneFn func()) {
}
}

// CheckValueViewReceiverIngestionBlockedRPCs checks that for the current exported value in the ViewReceiverReceivedSpans
// CheckValueViewReceiverIngestionBlockedRPCs checks that for the current exported value in the ViewReceiverIngestionBlockedRPCs
// for {TagKeyReceiver: receiverName, TagKeyExporter: exporterTagName} is equal to "value".
// In tests that this function is called it is required to also call SetupRecordedMetricsTest as first thing.
func CheckValueViewReceiverIngestionBlockedRPCs(receiverName string, value int) error {
return checkValueForView(observability.ViewReceiverIngestionBlockedRPCs.Name,
wantsTagsForReceiverView(receiverName), int64(value))
}

// CheckValueViewReceiverIngestionBlockedRPCsWithDataLoss checks that for the current exported value in the ViewReceiverReceivedSpans
// CheckValueViewReceiverIngestionBlockedRPCsWithDataLoss checks that for the current exported value in the ViewReceiverIngestionBlockedRPCsWithDataLoss
// for {TagKeyReceiver: receiverName, TagKeyExporter: exporterTagName} is equal to "value".
// In tests that this function is called it is required to also call SetupRecordedMetricsTest as first thing.
func CheckValueViewReceiverIngestionBlockedRPCsWithDataLoss(receiverName string, value int) error {
Expand Down
2 changes: 1 addition & 1 deletion receiver/zipkinreceiver/trace_receiver.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import (
"encoding/json"
"errors"
"fmt"
"github.com/open-telemetry/opentelemetry-service/config/configmodels"
"io"
"io/ioutil"
"net"
Expand All @@ -37,6 +36,7 @@ import (
zipkinproto "github.com/openzipkin/zipkin-go/proto/v2"
"go.opencensus.io/trace"

"github.com/open-telemetry/opentelemetry-service/config/configmodels"
"github.com/open-telemetry/opentelemetry-service/consumer"
"github.com/open-telemetry/opentelemetry-service/consumer/consumerdata"
"github.com/open-telemetry/opentelemetry-service/internal"
Expand Down
2 changes: 1 addition & 1 deletion receiver/zipkinreceiver/trace_receiver_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ package zipkinreceiver
import (
"bytes"
"fmt"
"github.com/open-telemetry/opentelemetry-service/config/configmodels"
"io"
"io/ioutil"
"net"
Expand All @@ -37,6 +36,7 @@ import (
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"

"github.com/open-telemetry/opentelemetry-service/config/configmodels"
"github.com/open-telemetry/opentelemetry-service/consumer"
"github.com/open-telemetry/opentelemetry-service/consumer/consumerdata"
"github.com/open-telemetry/opentelemetry-service/exporter/exportertest"
Expand Down

0 comments on commit 53789c0

Please sign in to comment.