Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement factory and config for "tail-sampling" processor #146

Closed
tigrannajaryan opened this issue Jul 10, 2019 · 0 comments · Fixed by #221
Closed

Implement factory and config for "tail-sampling" processor #146

tigrannajaryan opened this issue Jul 10, 2019 · 0 comments · Fixed by #221
Assignees
@songy23
Labels
help wanted Good issue for contributors to OpenTelemetry Service to pick up
Milestone
0.1.0

Comments

@tigrannajaryan
Copy link
Member

tigrannajaryan commented Jul 10, 2019 •
edited
Loading

See config.go/factory.go in "addattributesprocessor" package as an example.
@tigrannajaryan tigrannajaryan added this to the 0.1.0 milestone Jul 10, 2019
@tigrannajaryan tigrannajaryan added the help wanted Good issue for contributors to OpenTelemetry Service to pick up label Jul 11, 2019
@songy23 songy23 self-assigned this Jul 17, 2019
songy23 added a commit to songy23/opentelemetry-service that referenced this issue Jul 26, 2019
@songy23
Add factory and update config for tail sampling processor
cd126ea 
Updates open-telemetry#146
@songy23 songy23 mentioned this issue Jul 26, 2019
Merged
songy23 added a commit to songy23/opentelemetry-service that referenced this issue Jul 26, 2019
@songy23
Add factory and update config for tail sampling processor
10d8c64 
Updates open-telemetry#146
songy23 added a commit to songy23/opentelemetry-service that referenced this issue Jul 30, 2019
@songy23
Add factory and update config for tail sampling processor
0572d4e 
Updates open-telemetry#146
songy23 added a commit to songy23/opentelemetry-service that referenced this issue Jul 30, 2019
@songy23
Add factory and update config for tail sampling processor
22bf721 
Updates open-telemetry#146
songy23 added a commit to songy23/opentelemetry-service that referenced this issue Jul 31, 2019
@songy23
Add factory and update config for tail sampling processor
a6e4016 
Updates open-telemetry#146
songy23 added a commit to songy23/opentelemetry-service that referenced this issue Jul 31, 2019
@songy23
Add factory and update config for tail sampling processor
362e144 
Updates open-telemetry#146
pjanotti pushed a commit that referenced this issue Jul 31, 2019
@songy23
Add factory and update config for tail sampling processor (#200)
69a2ad0 
* Add factory and update config for tail sampling processor

Updates #146

* Move to package processor

* Remove an unnecessary check

* Move CreateDefaultConfig to factory and add unit tests

* Fix test failure

* Remove commented code
songy23 added a commit to songy23/opentelemetry-service that referenced this issue Jul 31, 2019
@songy23
Move tail sampling config to its own package and remove stale configs
c35271b 
Follow up of open-telemetry#200. Second step of open-telemetry#146.
@songy23 songy23 mentioned this issue Jul 31, 2019
Merged
pjanotti pushed a commit that referenced this issue Aug 1, 2019
@songy23
Move tail sampling config to its own package and remove stale configs (…
d0b9b47 
…#217)

Follow up of #200. Second step of #146.
songy23 added a commit to songy23/opentelemetry-service that referenced this issue Aug 2, 2019
@songy23
Finish up configs for tail sampling policies
360aa05 
Fixes open-telemetry#146.

Note one additional change is now each tail sampling processor can only
accept one policy, because one processor can only have one next
consumer. If users need more than one policies they can define multiple
tail sampling processors in the config.
@songy23 songy23 mentioned this issue Aug 2, 2019
Merged
songy23 added a commit to songy23/opentelemetry-service that referenced this issue Aug 2, 2019
@songy23
Finish up configs for tail sampling policies
4333aed 
Fixes open-telemetry#146.

Note one additional change is now each tail sampling processor can only
accept one policy, because one processor can only have one next
consumer. If users need more than one policies they can define multiple
tail sampling processors in the config.
songy23 added a commit to songy23/opentelemetry-service that referenced this issue Aug 2, 2019
@songy23
Finish up configs for tail sampling policies
cf02138 
Fixes open-telemetry#146.

Note one additional change is now each tail sampling processor can only
accept one policy, because one processor can only have one next
consumer. If users need more than one policies they can define multiple
tail sampling processors in the config.
songy23 added a commit to songy23/opentelemetry-service that referenced this issue Aug 2, 2019
@songy23
Finish up configs for tail sampling policies
539f9a9 
Fixes open-telemetry#146.

Note one additional change is now each tail sampling processor can only
accept one policy, because one processor can only have one next
consumer. If users need more than one policies they can define multiple
tail sampling processors in the config.
songy23 added a commit to songy23/opentelemetry-service that referenced this issue Aug 2, 2019
@songy23
Finish up configs for tail sampling policies
2be610e 
Fixes open-telemetry#146.

Note one additional change is now each tail sampling processor can only
accept one policy, because one processor can only have one next
consumer. If users need more than one policies they can define multiple
tail sampling processors in the config.
songy23 added a commit to songy23/opentelemetry-service that referenced this issue Aug 5, 2019
@songy23
Finish up configs for tail sampling policies
353332a 
Fixes open-telemetry#146.
pjanotti pushed a commit that referenced this issue Aug 7, 2019
@dinooliva
Migrate updates to Prometheus receiver from opencensus-service (#208)
22b9a57 
* Migrate updates to Prometheus receiver from opencensus-service

* Remove unnecessary configuration for adjusting metrics

* Update exporters README (#210)

Remove stale content, put in place a simple skeleton, and put information for the Zipkin exporter.

* Added Jaeger gRPC receiver (#197)

* Added Jaeger gRPC receiver

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>

* Addressed first review round

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>

* Changes based on the feedback from the second review

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>

* Fixed import order, check for same ip:port on endpoints

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>

* Reverted the port-check

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>

* Fix README - remove broken links and commands (#211)

Signed-off-by: Hui Kang <kangh@us.ibm.com>

* Refactor opencensus exporter to make it easily extensible (#212)

Refactored oc exporter code to make it easier to import in derived
builds without copying all the code.

Example derived exporter: https://github.com/owais/example-derived-oc-exporter

- Moved internal/compression to root
- Split opencensusexporter factory's `CreateTraceExporter` method into
  - `OCAgentOptions` and `CreateOCAgent`

* Use sha256 instead of md5 in node batcher processor (#202)

MD5 is insecure cryptographic hash functions, and are therefore unsuitable for security applications.

* Add goimports check and fix import order for all files (#209)

* Add goimports check and fix import order for all files

Updates #155.

* Try specifying a version for goimports

* Show the diff instead of files and fix import

* Fix default in Makefile

* Add factory and update config for tail sampling processor (#200)

* Add factory and update config for tail sampling processor

Updates #146

* Move to package processor

* Remove an unnecessary check

* Move CreateDefaultConfig to factory and add unit tests

* Fix test failure

* Remove commented code

* Add misspell check and fix all typos (#214)

* Add misspell check and fix all typos

Updates #155.

* Format

* Include yaml files

* Move tail sampling config to its own package and remove stale configs (#217)

Follow up of #200. Second step of #146.

* Add Observability Vision document (#188)

* Add Observability Vision document

This is a guidance document that developers can consult with when
working on improving own observability of OpenTelemetry Service.

* PR fixes

* Add Zipkin exporter factory (#207)

* Add Zipkin exporter factory

Add the Zipkin exporter configuration factory using the new configuration format. This does not bring many of the settings from the old configuration since they won't be used. In a sub-sequent PR the code of the exporter itself will be changed.

* PR Feedback: add 1 test plus some comments

* Rename endpoint to http-url and related field

* Fix goimports issue

* Remove TODO commented code

Replaced the TODO commented code with an issue.

* Rename the field used to specify destination

* Update README to address reviewer comments.

* Update module dependencies and import order for metricfamily

* Improve OC Receiver Documentation (#203)

* First round of receiver and opencensus receiver documentation.

* Undo go mod/sum changes

* Address initial set of comments.

* Address next set of comments.

* Address next set of comments.

* Fix use of server instead of receiver in comment and explain settings can be mix and matched.

* Merged master and fixed mispell error caugh with new tools

* Add static check and fix all errors (#218)

* Add static check

Fixes #155.

* Fix most staticcheck errors

* More fixes

* Fix id_batcher

* Rename exporterhelp parameter (#220)

The paramater was named exportFormat but it actually used as the exporter name.

* Fix build: lower casing error message (#224)

* Add jaeger grpc exporter (#219)

* Add Jaeger gRPC exporter

Adds a Jaeger gRPC exporter.

* Update exporters/README.md

* Fixes on the exporter/README.md

* Add doc.go with package description.

* Fix import order on config_test.go

* Migrate updates to Prometheus receiver from opencensus-service

* Remove unnecessary configuration for adjusting metrics

* Update README to address reviewer comments.

* Update module dependencies and import order for metricfamily

* Fix goimports

* Fix staticcheck issues
pjanotti pushed a commit that referenced this issue Aug 7, 2019
@songy23
Finish up configs for tail sampling policies (#221)
c4d4adf 
* Finish up configs for tail sampling policies

Fixes #146.

* Add tailsampling processor to defaults

* Restore multiple policies per instance of tail sampling processor

* Remove the -filter suffix
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this issue Nov 11, 2021
@ymotongpoo @rghetia
Add Stackdriver Trace exporter for trace. (open-telemetry#160)
9ed9798 
* Add Stackdriver Trace exporter for trace.

TODOs for future work is:

* to replace bundler.Bundler

* to add proper tests for the exporter

* to move the exporter to proper repository once it will be created.

* Change to use functions for the exporter initialization instead of
passing option struct directly.
This fix is aliging the same fix for Jaeger (open-telemetry#146, open-telemetry#161)

* Change Option struct to be function type

* Change the original Option struct to be private

* Add line comments to maxMessageEventsPerSpan to leave it for future implementation

* Fix unnessesary expressions specified by `make precommit`

Left errors by `make precommit` in experimental/bridge/opentracing.

* Ran make precommit

* Add new line at EOF

* WIP: Start implementing BatchSpanExporter interfaces

* Change to use RegisterSpanProcessor to register bsp

* Change function names to fit current implementation of sdk

* Removed google.golang.org/api/support/bundler and implement ssp and bsp

* Change spanProcessor as a member of Exporter.

* Fix option names used for BatchSpanProcessor initialization.

* Change Exporter.Shutdown just to unregister spanProcessor.

* Removed copyright statements of OpenCensus.

* Fix small typo and EOF new line

* Fix interfaces of ExportSpan/ExportSpans to meet SpanSyncer/SpanBatcher

* Change to follow context.Context passed in ExportSpan/ExportSpans

* Fix Stackdriver Exporter to hold sync.Once to lock when it is registered and
unregistered.
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
@dependabot
Bump go.opentelemetry.io/otel (open-telemetry#146)
437fac0 
Bumps [go.opentelemetry.io/otel](https://github.com/open-telemetry/opentelemetry-go) from 0.17.0 to 0.18.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v0.17.0...v0.18.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@songy23 songy23

Labels
help wanted Good issue for contributors to OpenTelemetry Service to pick up
Projects
None yet
Milestone
0.1.0
Development

Successfully merging a pull request may close this issue.

Finish up configs for tail sampling policies songy23/opentelemetry-service
2 participants
@tigrannajaryan @songy23