Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend receiverhelper Scraping library #2036

Closed
james-bebbington opened this issue Oct 29, 2020 · 0 comments
Closed

Extend receiverhelper Scraping library #2036

james-bebbington opened this issue Oct 29, 2020 · 0 comments
Labels
area:receiver enhancement New feature or request priority:p2 Medium release:allowed-for-ga Stale

Comments

@james-bebbington
Copy link
Member

james-bebbington commented Oct 29, 2020 •
edited
Loading

To resolve #934, we created a library to simplify creating receiver components that "scrape" data, see scraper & scraper controller in: https://github.com/open-telemetry/opentelemetry-collector/tree/master/receiver/receiverhelper

After applying this library to the hostmetrics receiver, my thoughts were that we could make this library even more usable if we:

  • Add ScraperFactory interfaces
  • Add code to simplify creation of scrapers via factories to receiver/receiverhelper

At that point, the Scraper interfaces will have many similarities in structure with other components, and it may arguably make sense to:

  • Move interfaces from receiver/receiverhelper/scraper.go into component/scraper.go

I don't think that scrapers should be a "top level component" though in the sense that they should be configurable at the top level like receivers / processors / exporters. Here's a doc @jrcamp and I were using a while back to discuss the idea of making Scraper a top level component which eventually led us to do none of the things in that doc and implement this as a library in receiverhelper instead: https://docs.google.com/document/d/15WKpYvw23rQ6WnBhoE2wdk4szfjlXEXg8WYYvBcKshA/edit
@james-bebbington james-bebbington mentioned this issue Oct 30, 2020
Merged
@bogdandrutu bogdandrutu mentioned this issue Nov 19, 2020
Merged
@andrewhsu andrewhsu added enhancement New feature or request and removed feature request labels Jan 6, 2021
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this issue Nov 11, 2021
@dependabot @MrAlias
Bump golang.org/x/tools from 0.1.3 to 0.1.4 in /internal/tools (open-…
57c2e8f 
…telemetry#2036)

* Bump golang.org/x/tools from 0.1.3 to 0.1.4 in /internal/tools

Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.1.3 to 0.1.4.
- [Release notes](https://github.com/golang/tools/releases)
- [Commits](golang/tools@v0.1.3...v0.1.4)

---
updated-dependencies:
- dependency-name: golang.org/x/tools
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@github-actions github-actions bot added the Stale label Jan 7, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 6, 2023
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this issue Jul 5, 2024
@johanpel
Pick old schema url when updating schema url is empty according to sp…
1ac9caf 
…ecification in Resource::Merge (open-telemetry#2036)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:receiver enhancement New feature or request priority:p2 Medium release:allowed-for-ga Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrewhsu @james-bebbington