Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common code for gRPC configuration settings #222

Closed
pjanotti opened this issue Aug 2, 2019 · 1 comment · Fixed by #340
Closed

Common code for gRPC configuration settings #222

pjanotti opened this issue Aug 2, 2019 · 1 comment · Fixed by #340

Comments

@pjanotti
Copy link
Contributor

pjanotti commented Aug 2, 2019

In principle there is no reason that receivers and exporters that use gRPC can't share the code to handle the gRPC configuration settings. This will enforce consistency and saves some code duplication.

Example: currently Jaeger gRPC exporter doesn't have a timeout or can use secure via configuration, however, the OC exporter has all these settings.

Related: #219 (comment)
@pjanotti
Copy link
Contributor Author

pjanotti commented Aug 2, 2019

This also means that this code should be a public package so others exporters/receivers outside core can also use it.

@inigohu inigohu mentioned this issue Sep 13, 2019
Merged
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this issue Nov 11, 2021
@jmacd
Observer metric has not been specified (open-telemetry#222)
1191a07
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
@rmfitzpatrick
Include SA bundle in msi (open-telemetry#222)
6467337 
* Include SA bundle w/ msi

* Set SPLUNK_BUNDLE_DIR in msi installations
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this issue Jul 5, 2024
@g-easy
Fix format on CI. (open-telemetry#222)
2d1cdea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add common gRPC configuration settings
1 participant
@pjanotti