Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker-component on Makefile fails on otelsvc #48

Closed
etsangsplk opened this issue Jun 24, 2019 · 8 comments
Closed

docker-component on Makefile fails on otelsvc #48

etsangsplk opened this issue Jun 24, 2019 · 8 comments
Assignees
@tigrannajaryan
Milestone
0.1.0

Comments

@etsangsplk
Copy link

etsangsplk commented Jun 24, 2019 •
edited
Loading

GO111MODULE=on CGO_ENABLED=0 go build -o ./bin/otelsvc_linux -ldflags "-X github.com/open-telemetry/opentelemetry-service/internal/version.GitHash=2a40f54 " ./cmd/otelsvc
cp ./bin/ocotelsvc_linux ./cmd/ocotelsvc/
cp: directory ./cmd/ocotelsvc does not exist

Because:

docker-component is assuming all component has a "oc" prefix.

docker-otelsvc:
COMPONENT=otelsvc $(MAKE) docker-component <<--
@tigrannajaryan
Copy link
Member

I can reproduce the failure on make docker-collector but not on make docker-otelsvc. The later passes successfully.

@tigrannajaryan
Copy link
Member

@pjanotti Rather than trying to fix I suggest to remove target docker-collector from makefile. We only need the unified docker-otelsvc.
Having docker-collector in the makefile is misleading and unnecessary.
Thoughts?

@pjanotti
Copy link
Contributor

I think it is a good idea since the collector is temporarily present just to help with compatibility tests, the real target is otelsvc.

@tigrannajaryan
Copy link
Member

Sounds good. I'll remove docker-collector target, but will keep collector which builds the binary and which can be used in compatibitity tests if needed (the testbed is executing the binary directly, it doesn't need the docker image).

@tigrannajaryan tigrannajaryan self-assigned this Jun 24, 2019
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Jun 24, 2019
Remove docker-collector makefile target
1f91845 
We only need the unified docker-otelsvc. Having docker-collector in
the makefile is misleading and unnecessary.

Issue: open-telemetry#48
@tigrannajaryan tigrannajaryan mentioned this issue Jun 24, 2019
Merged
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Jun 25, 2019
Remove docker-collector makefile target
478bc80 
We only need the unified docker-otelsvc. Having docker-collector in
the makefile is misleading and unnecessary.

Issue: open-telemetry#48
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Jun 25, 2019
Remove docker-collector makefile target
1c9c1fd 
We only need the unified docker-otelsvc. Having docker-collector in
the makefile is misleading and unnecessary.

Issue: open-telemetry#48
@tigrannajaryan
Copy link
Member

@etsangsplk docker-component target does not depend on otelsvc target. Can you provide exact reproduction steps? Are you running make docker-otelsvc on Mac?

Also, where do you see oc$(COMPONENT)? It is nowhere in makefile.

@etsangsplk
Copy link
Author

Mine repo is old. It was removed 4 days ago. Sync to master and it is now fine.

8772c90

@tigrannajaryan
Copy link
Member

OK, good to know. Thanks for reporting the issue anyway. I am going to remove docker-component target to avoid confusion in the future.

tigrannajaryan added a commit that referenced this issue Jun 25, 2019
@tigrannajaryan
Remove docker-collector makefile target (#50)
026061c 
We only need the unified docker-otelsvc. Having docker-collector in
the makefile is misleading and unnecessary.

Issue: #48
@tigrannajaryan
Copy link
Member

Done, closing the issue.

@flands flands added this to the 0.1.0 milestone Jun 28, 2019
pmm-sumo referenced this issue in pmm-sumo/opentelemetry-collector Jan 25, 2021
@pmm-sumo
Merge pull request #48 from SumoLogic/span-filtering
6795013 
Add span filtering capability
bogdandrutu added a commit that referenced this issue Oct 28, 2021
@jpkrohling @bogdandrutu
@joe-elliott @jiwen624 @Ashmita152 @fangyi-zhou @crearys @pmalek-sumo @secat @sodabrew @pmalek @KKelvinLo @himanshu007-creator @u5surf @zchee @Aneurysm9 @loomis-relativity
Move opentelemetry-collector-builder to core (#4286)
4063a46 
* Initial commit

* Add CODEOWNERS file (#2)

* Add CODEOWNERS file

* Update CODEOWNERS

* Moved from github.com/observatorium/opentelemetry-collector-builder (#3)

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>

* fixed panics (#6)

Signed-off-by: Joe Elliott <number101010@gmail.com>

* Replace master with main in CI and mergify files (#8)

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>

* Bump to OpenTelemetry Collector 0.20.0 (#10)

Closes #9

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>

* Explicitly enable Go modules in quickstart instructions (#13)

* Update to collector v0.21.0 (#17)

Fixes #16

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>

* Update to collector v0.22.0 (#19)

* Download go modules before building (#20)

Fixes #14

* Add version command (#25)

Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com>

* Pass errors from cobra Execute back to main for correct exit code (#28)

* pass errors from cobra execute back to main

* print the error

* Update to collector v0.23.0 (#27)

* Generate a warning if the builder and collector base version mismatch (#30)

* Generate a warning if the builder and collector base version mismatch

* Show current default version in the warning message

* Update to OpenTelemetry Collector 0.24.0

* Don't use %w formatting with log.Fatal (#35)

* Update to OpenTelemetry Collector 0.25.0 (#36)

Signed-off-by: Serge Catudal <serge.catudal@gmail.com>

* Update to 0.26.0 and update BuildInfo (#39)

* Sync build and CI Go versions at latest 1.16 (#34)

* Sync build and CI Go versions at latest 1.16

* Run go mod tidy

* Set go binary to use in the compilation phase in tests

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>

Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de>

* Add option to generate go code only (no compile) (#40)

* Issue#24 Add option to generate go code only (no compile)

* Update cmd/root.go logging

Suggested by @jpkkrohling

Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de>

* remove verbose help .. created by corba

* suggestion by jpkrohling to keep generateandcompile

* lint error: remove unused var

* reword cmd option and add back help message for default

Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de>

* Don't reuse exec.Cmd (#42)

* Update to OpenTelemetry Collector 0.27.0 (#43)

* Add CI Badge (#47)

* Update to Collector v0.28.0 (#49)

* Update to Collector v0.28.0

Closes #48

Addresses the breaking API change in
#3163,
besides the usual version number changes.

Signed-off-by: Fangyi Zhou <me@fangyi.io>

* Use `go mod tidy` instead of `go mod download`

It appears that this magically resolves the go.mod file issue.
https://stackoverflow.com/questions/67203641/missing-go-sum-entry-for-module-providing-package-package-name

Signed-off-by: Fangyi Zhou <me@fangyi.io>

* Account for go mod download in go1.17 not updating go.sum (#50)

* Update to collector v0.29.0 (#54)

* Update replaces.builder.yaml

* Update nocore.builder.yaml

* Update config.go

* Update README.md

* Update main.go

* Update to collector v0.30.0 (#57)

* cmd: fix module flag default value to github.com/open-telemetry (#58)

Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>

* Update to collector v0.31.0 (#60)

* Update to v0.33.0 (#62)

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>

* Add excludes support to generated go.mod (#63)

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>

Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de>

* Small cleanup for the builder files (#64)

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

* Support building with Go 1.17 (#66)

* Support building with Go 1.17
Fixes #65

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>

* Update workflows to use Go 1.17

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>

* Add gosec exceptions for exec.Command

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>

* Update to OpenTelemetry core 0.34.0 (#68)

Fixes #67

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>

* Upgrade to OpenTelemetry Collector 0.35.0 (#70)

Signed-off-by: Fangyi Zhou <me@fangyi.io>

* Upgrade to OpenTelemetry Collector 0.36.0 (#76)

* Generate custom service code for Windows (#75)

* update main to include windows service code

* use main version from tag 0.35.0

* update main function

* align with upstream v0.36.0 tag

* dummy change to trigger build

* Revert "dummy change to trigger build"

This reverts commit 629d499461da2d2c240bf1e495b5fe0558e3547f.

* Remove Core from Module type (#77)

Fixes #15

Signed-off-by: yugo-horie <u5.horie@gmail.com>

* release 0.37.0 (#78)

* release 0.37.0

* update use of NewCommand

* Move builder to subdirectory

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>

Co-authored-by: Bogdan Drutu <lazy@splunk.com>
Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
Co-authored-by: Joe Elliott <joe.elliott@grafana.com>
Co-authored-by: Eric Yang <jiwen624@gmail.com>
Co-authored-by: Brian Gibbins <eroteme@supernought.co.uk>
Co-authored-by: Ashmita <ashmita.bohara152@gmail.com>
Co-authored-by: Fangyi Zhou <me@fangyi.io>
Co-authored-by: Shaun Creary <65406540+crearys@users.noreply.github.com>
Co-authored-by: Patryk Małek <69143962+pmalek-sumo@users.noreply.github.com>
Co-authored-by: Serge Catudal <serge.catudal@gmail.com>
Co-authored-by: Aaron Stone <aaron@serendipity.cx>
Co-authored-by: Patryk Małek <pmalek@sumologic.com>
Co-authored-by: Aaron Stone <aaron.stone@udacity.com>
Co-authored-by: Kelvin Lo <kello@live.ca>
Co-authored-by: Himanshu <addyjeridiq@gmail.com>
Co-authored-by: Y.Horie <u5.horie@gmail.com>
Co-authored-by: Koichi Shiraishi <zchee.io@gmail.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Co-authored-by: Cal Loomis <68860480+loomis-relativity@users.noreply.github.com>
Co-authored-by: alrex <aboten@lightstep.com>
bogdandrutu pushed a commit that referenced this issue Oct 28, 2021
@fangyi-zhou
Update to Collector v0.28.0 (#49)
16563b6 
* Update to Collector v0.28.0

Closes #48

Addresses the breaking API change in
#3163,
besides the usual version number changes.

Signed-off-by: Fangyi Zhou <me@fangyi.io>

* Use `go mod tidy` instead of `go mod download`

It appears that this magically resolves the go.mod file issue.
https://stackoverflow.com/questions/67203641/missing-go-sum-entry-for-module-providing-package-package-name

Signed-off-by: Fangyi Zhou <me@fangyi.io>
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this issue Nov 11, 2021
@jmacd @rghetia
Eliminate Scope/ScopeID, separate API from SDK for metrics/stats (ope…
9611216 
…n-telemetry#48)

* Move scope.Active to trace.CurrentSpan

* Remove scope / does not build

* Global tracer

* Checkpoint

* Checkpoint

* Add key/key.go for key.New

* Comments

* Remove more EventID and ScopeID

* Use Handle to describe static objects

* TODOs

* Remove empty file

* Remove singletons

* Update TODOs

* TODO about map update

* Make stats package option aliases (like key has)

* Rename experimental/streaming

* streaming SDK builds w/ many TODOs

* Get the examples building

* Tidy up metric API / add interface check

* Remove logic from the registry; this is now a placeholder
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
@flands
Add SPLUNK_MEMORY_TOTAL_MIB (open-telemetry#48)
adc00a6 
Today, SPLUNK_BALLAST_SIZE_MIB needs to be computed and manually
configured by a user. Most users do not know or care about the ballast
and under normal circumstances they should not need to. Users will
understand the total amount of memory allocated to the Collector. As
such, introduce a SPLUNK_MEMORY_TOTAL_MIB env var that can be used
instead of or in addition to SPLUNK_BALLAST_SIZE_MIB. This has the added
bonus that now memory spike and limit env vars are no longer required
for non-linux systems. This change is backwards compatible.

A few other minor enhancements:

- Memory spike/limit env vars are now applied even if SPLUNK_CONFIG is
  passed
- Add logging for custom behavior so configuration is clear
- Add accessible endpoints to README
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this issue Jul 5, 2024
A little CMake cleanup (open-telemetry#48)
97ea4d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tigrannajaryan tigrannajaryan

Labels
None yet
Projects
None yet
Milestone
0.1.0
Development

No branches or pull requests
4 participants
@flands @tigrannajaryan @pjanotti @etsangsplk