Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce connectorprofiles.NewProfilesRouter #11023

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Introduce connectorprofiles.NewProfilesRouter #11023

merged 3 commits into from
Sep 3, 2024

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Aug 30, 2024 •
edited
Loading

Description

I missed the connector router when setting up connectorprofiles.

cc @mx-psi

@codecov Codecov
Copy link

codecov bot commented Aug 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.22%. Comparing base (cd1f762) to head (a1706e9).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
connector/connectorprofiles/profiles_router.go 87.50% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11023   +/-   ##
=======================================
  Coverage   92.21%   92.22%           
=======================================
  Files         408      409    +1     
  Lines       19126    19134    +8     
=======================================
+ Hits        17637    17646    +9     
  Misses       1127     1127           
+ Partials      362      361    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmathieu dmathieu marked this pull request as ready for review August 30, 2024 12:00
@dmathieu dmathieu requested review from a team and mx-psi August 30, 2024 12:00
@dmathieu dmathieu mentioned this pull request Aug 30, 2024
Merged
@mx-psi mx-psi merged commit d0fde2f into open-telemetry:main Sep 3, 2024
49 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 3, 2024
@dmathieu dmathieu deleted the connector-profiles-router branch September 3, 2024 09:13
mx-psi pushed a commit that referenced this pull request Sep 5, 2024
@dmathieu
Add profiles support in service (#11024)
720f3a8 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This is the last PR to add profiles support, adding it to the service
package.

This is based after #11023.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.109.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dmathieu @mx-psi