Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter] [chore] Initialize batchSender and queueSender after configuration - #1 #11041

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

sfc-gh-sili
Copy link
Contributor

@sfc-gh-sili sfc-gh-sili commented Sep 4, 2024

Description

This PR changes initialization of batchSender and queueSender to AFTER configuration. That way we get to access queueConfig and batcherConfig in the same place.

Context: This is some pre-work for changing queue->batch from a pushing model to a pulling model. We will be initialization a queueBatchSender(queueConfig, batcherConfig) if both queue and batcher are enabled and initialize batchSender(batchConfig) if only batcher is enabled. This change enables us to achieve the goal without changing config API.

Link to tracking issue

#10368

Testing

Ran opentelemetry-collector$ make to make sure all tests still pass.

@sfc-gh-sili sfc-gh-sili changed the title Initialize after configuring [exporter] Initialize batchSender and queueSender after configuration Sep 4, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.23%. Comparing base (a26068b) to head (67e094d).
Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11041   +/-   ##
=======================================
  Coverage   92.23%   92.23%           
=======================================
  Files         406      406           
  Lines       19101    19108    +7     
=======================================
+ Hits        17618    17625    +7     
  Misses       1123     1123           
  Partials      360      360           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-sili sfc-gh-sili marked this pull request as ready for review September 4, 2024 07:24
@sfc-gh-sili sfc-gh-sili requested review from a team and jpkrohling September 4, 2024 07:24
@sfc-gh-sili sfc-gh-sili changed the title [exporter] Initialize batchSender and queueSender after configuration [exporter] [chore] Initialize batchSender and queueSender after configuration Sep 4, 2024
@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 4, 2024
@mx-psi mx-psi requested a review from dmitryax September 4, 2024 10:20
@mx-psi
Copy link
Member

mx-psi commented Sep 4, 2024

Will merge by Friday if there are not further comments

@mx-psi mx-psi merged commit 7966035 into open-telemetry:main Sep 6, 2024
49 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 6, 2024
@sfc-gh-sili sfc-gh-sili changed the title [exporter] [chore] Initialize batchSender and queueSender after configuration [exporter] [chore] Initialize batchSender and queueSender after configuration - #1 Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants