Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][component/componenttest] Clarify wording in some comments #11068

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

crobert-1
Copy link
Member

Description

This is a documentation-only change, just cleaning up some wording of comments.

@crobert-1 crobert-1 requested review from a team and mx-psi September 5, 2024 22:31
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.20%. Comparing base (e99074d) to head (1fdf19a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11068   +/-   ##
=======================================
  Coverage   92.20%   92.20%           
=======================================
  Files         405      405           
  Lines       19244    19244           
=======================================
  Hits        17743    17743           
  Misses       1134     1134           
  Partials      367      367           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I am going to merge since I think this is a net improvement but I wonder if we should explicitly test that SetupTelemetry has been called and panic if not

@mx-psi mx-psi merged commit 8dd758e into open-telemetry:main Sep 6, 2024
49 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants