Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scraperhelper] remove deprecated obsreport funcs/structs #11086

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

codeboten
Copy link
Contributor

These were only used inside scraperhelper, should have no impact.

These were only used inside scraperhelper, should have no impact.

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten marked this pull request as ready for review September 9, 2024 17:19
@codeboten codeboten requested review from a team and jpkrohling September 9, 2024 17:19
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.21%. Comparing base (3f9bc53) to head (fbb7e08).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11086   +/-   ##
=======================================
  Coverage   92.20%   92.21%           
=======================================
  Files         414      414           
  Lines       19804    19802    -2     
=======================================
  Hits        18261    18261           
+ Misses       1170     1168    -2     
  Partials      373      373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeboten codeboten merged commit 46d04a5 into open-telemetry:main Sep 9, 2024
48 of 49 checks passed
@codeboten codeboten deleted the codeboten/rm-dep-funs branch September 9, 2024 17:49
@github-actions github-actions bot added this to the next release milestone Sep 9, 2024
dmathieu pushed a commit to dmathieu/opentelemetry-collector that referenced this pull request Sep 10, 2024
…etry#11086)

These were only used inside scraperhelper, should have no impact.

---------

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants