Change Zipkin receiver behavior according to host ingestion status #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjanotti
requested review from
bogdandrutu,
flands,
songy23 and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
==========================================
+ Coverage 73.05% 73.69% +0.63%
==========================================
Files 95 95
Lines 5789 5827 +38
==========================================
+ Hits 4229 4294 +65
+ Misses 1350 1318 -32
- Partials 210 215 +5
Continue to review full report at Codecov.
|
| var responseStatusCode int | ||
| var zPageMessage string | ||
| if zr.backPressureState == configmodels.EnableBackPressure { | ||
| responseStatusCode = http.StatusServiceUnavailable |
There was a problem hiding this comment.
In the future we can also try to be smart and calculate queue drain speed and the time it will be required for it to drain to certain reasonable level and report that in "Retry-After" header. Not for this PR, just something to consider for later.
added 3 commits
July 11, 2019 14:47
This change makes the Zipkin receiver respond to received data according to the host status regarding ingestion.
pjanotti
force-pushed
the
zipkin-receiver-ingestion-response
branch
from
9048b08
to
47e0826
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the Zipkin receiver respond to received data according to the host ingestion status.
This is part of #76