translator/conventions: add deployment.environment #1691
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a constant for the recently introduced deployment environment resource attribute: open-telemetry/opentelemetry-specification#606
axw
requested review from
bogdandrutu,
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1691 +/- ##
==========================================
- Coverage 92.33% 92.32% -0.01%
==========================================
Files 265 265
Lines 19811 19812 +1
==========================================
- Hits 18292 18291 -1
- Misses 1090 1091 +1
- Partials 429 430 +1
Continue to review full report at Codecov.
|
|
Please wait for open-telemetry/opentelemetry-specification#851 to finish |
|
open-telemetry/opentelemetry-specification#851 is now merged. |
|
Didn't see this, I added it in a later PR #1722 |
|
No worries, thanks! |
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…metry#1691) Bumps [github.com/jaegertracing/jaeger](https://github.com/jaegertracing/jaeger) from 1.35.1 to 1.35.2. - [Release notes](https://github.com/jaegertracing/jaeger/releases) - [Changelog](https://github.com/jaegertracing/jaeger/blob/main/CHANGELOG.md) - [Commits](jaegertracing/jaeger@v1.35.1...v1.35.2) --- updated-dependencies: - dependency-name: github.com/jaegertracing/jaeger dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a constant for the recently introduced deployment environment resource attribute: open-telemetry/opentelemetry-specification#606