Convert status to not be a pointer in the Span #2242
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2242 +/- ##
==========================================
- Coverage 92.13% 92.10% -0.03%
==========================================
Files 272 272
Lines 15313 15284 -29
==========================================
- Hits 14109 14078 -31
- Misses 827 828 +1
- Partials 377 378 +1
Continue to review full report at Codecov.
|
| if status.IsNil() { | ||
| return nil, nil | ||
| } | ||
|
|
There was a problem hiding this comment.
Should we return (nil, nil) if status.Code()==case pdata.StatusCodeUnset && status.message==""?
There was a problem hiding this comment.
Not sure, was thinking about that as well. Is that not a different change? That behavior was not there before. Do you suggest to do this?
There was a problem hiding this comment.
Because we now don't have a pointer to Status this case will happen always for all successful statuses, so it is a bit more important now. But, probably doesn't matter much, it only affects OpenCensus format. Let's leave as is and we can change in the future if needed.
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
statusnil
branch
from
268e576
to
e999bd3
Compare
We previously were recording the Schema URL but were not setting the recorded value when exporting. This change now uses the recorded value when exporting to OTLP.
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com