Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SignalTestComplete to Shutdown #2277

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Rename SignalTestComplete to Shutdown #2277

merged 1 commit into from
Dec 11, 2020

Conversation

rakyll
Copy link
Contributor

@rakyll rakyll commented Dec 11, 2020

SignalTestComplete shouldn't be in the public API and Application should provide a Shutdown method instead. This change is fixing the public API, behavior of Shutdown will be fixed in the future.

Fixes #2260.

SignalTestComplete shouldn't be in the public API and Application should provide a Shutdown method instead. This change is fixing the public API, behavior of Shutdown will be fixed in the future.

Fixes #2260.
@rakyll rakyll requested a review from a team December 11, 2020 01:44
@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #2277 (576f1b7) into master (7eb2628) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2277      +/-   ##
==========================================
- Coverage   92.04%   92.02%   -0.02%     
==========================================
  Files         272      272              
  Lines       15284    15266      -18     
==========================================
- Hits        14068    14049      -19     
  Misses        837      837              
- Partials      379      380       +1     
Impacted Files Coverage Δ
service/service.go 52.67% <ø> (ø)
config/configcheck/configcheck.go 100.00% <0.00%> (ø)
internal/data/bytesid.go 80.95% <0.00%> (+4.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eb2628...576f1b7. Read the comment docs.

Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@tigrannajaryan tigrannajaryan merged commit 4d60560 into open-telemetry:master Dec 11, 2020
tigrannajaryan pushed a commit that referenced this pull request Jul 8, 2021
This is follow up to #2277. The internal channel must have been renamed too.
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
For some reason `porto` doesn't work here?
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename service.Application.SignalTestComplete to Shutdown
2 participants