Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Go1.16 #3010

Merged
merged 1 commit into from
Apr 24, 2021
Merged

Upgrade to Go1.16 #3010

merged 1 commit into from
Apr 24, 2021

Conversation

owais
Copy link
Contributor

@owais owais commented Apr 23, 2021

Description:

Updated CI and makefile to use Go 1.16.

In 1.16, go install accepts versions so the tools trick to pin tool versions is not required anymore.

@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #3010 (e25096a) into main (1e740d0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3010   +/-   ##
=======================================
  Coverage   92.05%   92.05%           
=======================================
  Files         313      313           
  Lines       15445    15445           
=======================================
  Hits        14218    14218           
  Misses        819      819           
  Partials      408      408           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e740d0...e25096a. Read the comment docs.

@owais owais marked this pull request as ready for review April 23, 2021 23:35
@owais owais requested a review from a team April 23, 2021 23:35
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In 1.16, go install accepts versions so the tools trick to pin tool versions is not required anymore.

The downside of not using the "tools trick" is that Dependabot will not be bumping the tools version anymore, which might not be desirable.

@owais
Copy link
Contributor Author

owais commented Apr 24, 2021

Good point. I think it also means go won't verify checksums in go.sum so probably better to keep tools. I'll add them back.

@owais owais requested a review from mx-psi April 24, 2021 15:53
@bogdandrutu bogdandrutu merged commit 73b55f0 into open-telemetry:main Apr 24, 2021
@owais owais deleted the go16 branch April 24, 2021 18:37
@mx-psi mx-psi mentioned this pull request May 6, 2021
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
…y#3010)

Bumps [boto3](https://github.com/boto/boto3) from 1.26.114 to 1.26.118.
- [Release notes](https://github.com/boto/boto3/releases)
- [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst)
- [Commits](boto/boto3@1.26.114...1.26.118)

---
updated-dependencies:
- dependency-name: boto3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants