add resource to vmreceiver.

[rghetia]

fixes #30.

[songy23]

LGTM

[codecov-io]

Codecov Report

Merging #31 into master will increase coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   68.94%   69.05%   +0.11%     
==========================================
  Files          82       84       +2     
  Lines        5461     5520      +59     
==========================================
+ Hits         3765     3812      +47     
- Misses       1480     1488       +8     
- Partials      216      220       +4

Impacted Files	Coverage Δ
receiver/prometheusreceiver/factory.go	72.09% <0%> (ø)
receiver/zipkinreceiver/factory.go	100% <0%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8772c90...e9d1eff. Read the comment docs.

[tigrannajaryan]

@pjanotti vmmetrics is not on the list of receivers that we wanted to have in the core, however we haven't discussed it explicitly. Any thoughts on this?

@rghetia for reference here is the currently approved list of what we agreed to have in the core: https://github.com/open-telemetry/opentelemetry-service/blob/master/docs/migrating-from-opencensus.md

If we decide that we do not want to include vmmetrics then this change belongs to the "contrib" repo (which doesn't exist yet).

[songy23]

I think vm metrics receiver should be in core. We didn't list it there because this receiver starts as an experimental component and lacks support for several platforms (e.g Windows, MacOS). Eventually it should be one of the default receivers.

[pjanotti]

@tigrannajaryan In a sense this is not actually a receiver but a scraper/extractor of metrics. It is a good addition to core because it allows value out of box: just by running otelsvc one can use it to have metrics collected and shipped to their preferred backend.

[pjanotti]

@rghetia a couple of questions.

[tigrannajaryan]

I think vm metrics receiver should be in core. We didn't list it there because this receiver starts as an experimental component and lacks support for several platforms (e.g Windows, MacOS). Eventually it should be one of the default receivers.

In a sense this is not actually a receiver but a scraper/extractor of metrics. It is a good addition to core because it allows value out of box: just by running otelsvc one can use it to have metrics collected and shipped to their preferred backend.

This sounds reasonable, let's make it part of the core.

[pjanotti]

Build failure was unrelated, created #43 to follow up. Kicked another build.

[rghetia]

@pjanotti , @songy23 can one of you please merge this? I don't have write access.