Standarize Settings, Params and Parameters #3163
Merged
Commits on May 21, 2021
-
Standarize Settings, Params and Parameters
Replace Parameters and settings structs with new struct Settings Replace dependencies in service and main Update tests Signed-off-by: Patryk Matyjasek <pmatyjasek@sumologic.com> # Conflicts: # service/application_windows.go
-
-
Rework Settings structure to fit all requirements.
Split it into ServiceSettings and ApplicationSettings. Signed-off-by: Patryk Matyjasek <pmatyjasek@sumologic.com> # Conflicts: # CHANGELOG.md # service/application_windows.go
-
- Fix import orders - Rename stutter structs Signed-off-by: Patryk Matyjasek <pmatyjasek@sumologic.com> # Conflicts: # CHANGELOG.md # service/application_windows.go
-
Make SvcSettings private Signed-off-by: Patryk Matyjasek <pmatyjasek@sumologic.com>
-
Remove unused Settings struct.
Fix Windows tests Signed-off-by: Patryk Matyjasek <pmatyjasek@sumologic.com>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.