Add readme about how to provide configuration to the collector #5507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This explains only how to provide the configuration via the `--config` file, after open-telemetry#4742 will update the embedded values option. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #5507 +/- ##
=======================================
Coverage 90.76% 90.76%
=======================================
Files 192 192
Lines 11477 11477
=======================================
Hits 10417 10417
Misses 831 831
Partials 229 229 Continue to review full report at Codecov.
|
|
Looks good to me, hope someone can approve for merge |
|
@mx-psi ? |
mx-psi
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This explains only how to provide the configuration via the
--configfile, after #4742 will update the embedded values option.Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com