[exporterhelper]: reduce default queue size to 1000 #7592
Merged
+30
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiatekm
force-pushed
the
fix/default-queue-size
branch
2 times, most recently
from
5781c05
to
6e8b292
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #7592 +/- ##
==========================================
- Coverage 91.23% 91.23% -0.01%
==========================================
Files 296 296
Lines 14472 14471 -1
==========================================
- Hits 13203 13202 -1
Misses 1004 1004
Partials 265 265
☔ View full report in Codecov by Sentry. |
swiatekm
force-pushed
the
fix/default-queue-size
branch
from
6e8b292
to
c2b6680
Compare
bogdandrutu
reviewed
May 3, 2023
swiatekm
force-pushed
the
fix/default-queue-size
branch
from
c2b6680
to
1e82eb7
Compare
swiatekm
force-pushed
the
fix/default-queue-size
branch
from
1e82eb7
to
324e1ed
Compare
dmitryax
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Reduce the default queue size to 1000. Combined with the defaults on batchprocessor, the current default of 5000 is too much and will lead to an OOMKill in most environments if actually filled.
1000 is probably too high still, but we don't want to make too drastic of a change here at once. See linked issue for specifics.
Link to tracking Issue: #7359
Documentation: Updated the relevant README