Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Update release docs based on 0.77.0 release #7647

Merged
merged 1 commit into from
May 10, 2023

Conversation

TylerHelmuth
Copy link
Member

Updates based on releasing Contrib and Release repos.

I encountered this error when pushing the tags in Contrib despite previous tags pushing as expected.

pushing tag exporter/googlemanagedprometheusexporter/v0.77.0
Enumerating objects: 1, done.
Counting objects: 100% (1/1), done.
Writing objects: 100% (1/1), 400 bytes | 9.00 KiB/s, done.
Total 1 (delta 0), reused 0 (delta 0), pack-reused 0
remote: fatal error in commit_refs
To https://github.com/open-telemetry/opentelemetry-collector-contrib.git
 ! [remote rejected]       exporter/googlemanagedprometheusexporter/v0.77.0 -> exporter/googlemanagedprometheusexporter/v0.77.0 (failure)
error: failed to push some refs to 'https://github.com/open-telemetry/opentelemetry-collector-contrib.git'
make: *** [push-tags] Error 1

I didn't try rerunning make push-tags bc it looked like it would try to re-push existing tags. If the real solution is to rerun the push-tags make target I'll update this PR.

@TylerHelmuth TylerHelmuth requested review from a team and dmitryax May 10, 2023 00:04
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8464b71) 91.25% compared to head (f7533bf) 91.25%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7647   +/-   ##
=======================================
  Coverage   91.25%   91.25%           
=======================================
  Files         296      296           
  Lines       14477    14477           
=======================================
  Hits        13211    13211           
  Misses       1002     1002           
  Partials      264      264           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bogdandrutu bogdandrutu merged commit d250165 into open-telemetry:main May 10, 2023
@github-actions github-actions bot added this to the next release milestone May 10, 2023
```bash
.PHONY: temp-push-tags
temp-push-tags:
for tag in `cat tags.txt`; do \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for tag in `cat tags.txt`; do \
for tag in `git tag | grep vX.Y.Z`; do \

This is the approach I usually take for Go SDK releases. Push all tags of the appropriate version. Hopefully easier than constructing a list of tags by hand.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Luckily I could copy and paste the list into the file bc the target printed it out, but I like this idea more.

@TylerHelmuth TylerHelmuth deleted the update-release-docs branch May 10, 2023 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants