Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add feature gate for supporting additional exporters #7678

Merged

Conversation

codeboten
Copy link
Contributor

This adds the feature-gate telemetry.useOtelWithExtendedConfigurationForInternalTelemetry to start adding support for additional exporters for the collector's internal telemetry.

This is part of of #7644

This adds the feature-gate `telemetry.useOtelWithExtendedConfigurationForInternalTelemetry` to start adding support for additional exporters for the collector's internal telemetry.

Signed-off-by: Alex Boten <aboten@lightstep.com>
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.05 ⚠️

Comparison is base (6542100) 91.31% compared to head (c244900) 91.27%.

❗ Current head c244900 differs from pull request most recent head a1ae42b. Consider uploading reports for the commit a1ae42b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7678      +/-   ##
==========================================
- Coverage   91.31%   91.27%   -0.05%     
==========================================
  Files         296      296              
  Lines       14485    14487       +2     
==========================================
- Hits        13227    13223       -4     
- Misses        995     1000       +5     
- Partials      263      264       +1     
Impacted Files Coverage Δ
internal/obsreportconfig/obsreportconfig.go 93.33% <ø> (ø)
service/telemetry/config.go 100.00% <ø> (ø)
service/service.go 77.19% <100.00%> (+0.13%) ⬆️
service/telemetry.go 89.22% <100.00%> (+0.06%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

internal/obsreportconfig/obsreportconfig.go Outdated Show resolved Hide resolved
service/telemetry/config.go Show resolved Hide resolved
internal/obsreportconfig/obsreportconfig.go Show resolved Hide resolved
.chloggen/codeboten_add-featuregate-telemetry.yaml Outdated Show resolved Hide resolved
Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten codeboten merged commit 0700d81 into open-telemetry:main May 16, 2023
@codeboten codeboten deleted the codeboten/add-featuregate-telemetry branch May 16, 2023 16:06
@github-actions github-actions bot added this to the next release milestone May 16, 2023
codeboten pushed a commit that referenced this pull request Jun 22, 2023
This is generated from the opentelemetry-configuration repository using
gojsonschema. Updated makefile to support this w/ `make genjsonschema`

Follow up to
#7678

---------

Signed-off-by: Alex Boten <aboten@lightstep.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants