Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for b3multi #36

Open
zdmytriv opened this issue Jun 11, 2021 · 1 comment
Open

Add support for b3multi #36

zdmytriv opened this issue Jun 11, 2021 · 1 comment

Comments

@zdmytriv
Copy link

Is your feature request related to a problem?
Need support for b3-multi for nginx module. https://github.com/openzipkin/b3-propagation#multiple-headers

Describe the solution you'd like
Implement b3-multi in similar fashion like it is with simple b3 just do not concat trace-span-sampled into on header.

Right now header looks like

"B3": "2605e09e4efca19056beee12767f6287-426bf077362e8477-1",

for b3-multi there should be 3 headers

X-B3-TraceId: 2605e09e4efca19056beee12767f6287
X-B3-SpanId: 426bf077362e8477
X-B3-Sampled: 1
kuzaxak added a commit to x-qdo/opentelemetry-cpp-contrib that referenced this issue Feb 1, 2022
Some services expect [B3 Multi][1] headers as input information.
To support that we need to be able to Inject them into upstream requests.

Tests will be added as a separate commit later on.

Solving open-telemetry#36

[1]: https://github.com/openzipkin/b3-propagation#multiple-headers
kuzaxak added a commit to x-qdo/opentelemetry-cpp-contrib that referenced this issue Feb 1, 2022
Some services expect [B3 Multi][1] headers as input information.
To support that we need to be able to Inject them into upstream requests. Lowercase headers used to be [compatible][2] with Istio Envoy.

Tests will be added as a separate commit later on.

Solving open-telemetry#36

[1]: https://github.com/openzipkin/b3-propagation#multiple-headers
[2]: open-telemetry/opentelemetry-go#765
kuzaxak added a commit to x-qdo/opentelemetry-cpp-contrib that referenced this issue Sep 8, 2022
Some services expect [B3 Multi][1] headers as input information.
To support that we need to be able to Inject them into upstream requests. Lowercase headers used to be [compatible][2] with Istio Envoy.

Tests will be added as a separate commit later on.

Solving open-telemetry#36

[1]: https://github.com/openzipkin/b3-propagation#multiple-headers
[2]: open-telemetry/opentelemetry-go#765
@kuzaxak
Copy link

kuzaxak commented Mar 4, 2023

@ThomsonTan Could you please have a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants