Skip to content

Commit

Permalink
Fix ETW log exporter header inclusion (#1426)
Browse files Browse the repository at this point in the history
  • Loading branch information
lalitb committed Jun 2, 2022
1 parent 93ef013 commit 81df64b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

# include "opentelemetry/common/key_value_iterable_view.h"

# include "opentelemetry/logs/tracer_provider.h"
# include "opentelemetry/logs/logger_provider.h"
# include "opentelemetry/trace/span_id.h"
# include "opentelemetry/trace/trace_id.h"

Expand Down
2 changes: 1 addition & 1 deletion exporters/etw/test/etw_logger_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
# include <map>
# include <string>

# include "opentelemetry/exporters/etw/etw_logger.h"
# include "opentelemetry/exporters/etw/etw_logger_exporter.h"
# include "opentelemetry/sdk/trace/simple_processor.h"

using namespace OPENTELEMETRY_NAMESPACE;
Expand Down

2 comments on commit 81df64b

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp sdk Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 81df64b Previous: 93ef013 Ratio
BM_AlwaysOffSamplerShouldSample 71.48094484942824 ns/iter 32.77942025164535 ns/iter 2.18
BM_AlwaysOnSamplerShouldSample 70.04860860030006 ns/iter 32.81513912976002 ns/iter 2.13
BM_ParentBasedSamplerShouldSample 72.65662776039628 ns/iter 35.467991106824776 ns/iter 2.05

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp api Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 81df64b Previous: 93ef013 Ratio
BM_SpanIdConstructor 3.1368208951869443 ns/iter 1.495195025773958 ns/iter 2.10

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.