-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename OpenTelemetry.Extensions.Docker to OpenTelemetry.ResourceDetectors.Container #869
Comments
If we're renaming this package now, this is probably a good time to consider the general proposal I have here open-telemetry/opentelemetry-dotnet#3469 for revising our naming strategy across our packages. Namely, I question the overuse of the word My suggestion for this package was to consider something more descriptive of what is in it: |
Namely, I question the overuse of the word Extensions in our package names. We use it for so many different kinds of packages that it effectively has no meaning. I agree. If we have the opportunity to make the package names more descriptive, we should.
We should also consider standardizing the usage of singular vs plural nouns in the package names. Do we want to name is |
Yep, good call. My vote singular as that keeps things consistent with our already stable packages (e.g., OpenTelemetry.Exporter.*). So in this case: |
I have one small concern. Originally we took a sample from |
A few others have asked this same question as well. It's a good reason not to jump into a name change too quickly. Here's some ideas
Personally, I'm leaning towards option 1 at the moment. However, admittedly, I have not thought very deeply about what other container-related extensions may come in the future. If there are specific ideas or examples related to containers you could share, that would be helpful. |
@alanwest, I like ide about small targeted packages and meta-package on top if needed. I like it especially for containers, as it is hard to imagine anything beyond resource detector now - as docker should not affect on anything executed inside, and if there will be some tool that specially manages docker/containers (and will require additional instrumentation for docker API calls), it probably will be highly-specialized that better to instrument with special package. |
* Changes Update CHANGELOG for 1.1.0-beta.1 release, that will include CGroup V2 support (open-telemetry#839, open-telemetry#693). It still have `-beta.1` suffix to make it prerelease until decision on package name will be done (open-telemetry#881, open-telemetry#869)
@Kielek, the name can be changed, as more generic name
OpenTelemetry.Extensions.Container
- but we already have first release of it at https://www.nuget.org/packages/OpenTelemetry.Extensions.Docker - we will need to deprecate old package in NuGet and add link to new package name there. I don't know how to do it, but hope it won't be too hard. We can create separate issue and discuss it there. Looks like nodejs have already renamed it tocontainer
.Originally posted by @iskiselev in #839 (comment)
The text was updated successfully, but these errors were encountered: