Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] Enable NugetAudit - finalize #2079

Merged
merged 10 commits into from
Sep 18, 2024
Merged

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Sep 17, 2024

Finalize: #2034

Changes

Enable NugetAudit across whole repository.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • [ ] Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@github-actions github-actions bot added infra Infra work - CI/CD, code coverage, linters documentation Improvements or additions to documentation labels Sep 17, 2024
@github-actions github-actions bot added comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva comp:extensions.enrichment Things related to OpenTelemetry.Extensions.Enrichment comp:instrumentation.wcf Things related to OpenTelemetry.Instrumentation.Wcf comp:sampler.aws Things related to OpenTelemetry.Samplers.AWS labels Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.69%. Comparing base (71655ce) to head (2f10200).
Report is 437 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2079      +/-   ##
==========================================
- Coverage   73.91%   69.69%   -4.23%     
==========================================
  Files         267      206      -61     
  Lines        9615     9035     -580     
==========================================
- Hits         7107     6297     -810     
- Misses       2508     2738     +230     

see 334 files with indirect coverage changes

@Kielek Kielek marked this pull request as ready for review September 17, 2024 18:44
@Kielek Kielek requested a review from a team September 17, 2024 18:44
Comment on lines +24 to +27
<!-- System.Text.RegularExpressions is indirect reference. It is needed to upgrade it directly to avoid https://github.com/advisories/GHSA-cmhx-cq75-c4mj -->
<PackageReference Include="System.Text.RegularExpressions" Version="4.3.1" />
<!-- System.Net.Http is indirect reference. It is needed to upgrade it directly to avoid https://github.com/advisories/GHSA-7jgj-8wvc-jh57 -->
<PackageReference Include="System.Net.Http" Version="4.3.4" />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be removed when is kaitai-io/kaitai_struct_csharp_runtime#21 merged and released.
Repo is almost not changing so I doubt that it will happen.

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit, but LGTM

Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>
@Kielek Kielek merged commit 378a1a3 into open-telemetry:main Sep 18, 2024
212 of 213 checks passed
@Kielek Kielek deleted the nuget-audit2 branch September 18, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva comp:extensions.enrichment Things related to OpenTelemetry.Extensions.Enrichment comp:instrumentation.wcf Things related to OpenTelemetry.Instrumentation.Wcf comp:sampler.aws Things related to OpenTelemetry.Samplers.AWS documentation Improvements or additions to documentation infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants