Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some bugs in Runtime metrics #409

Merged
merged 11 commits into from
Jun 10, 2022
Merged

Conversation

xiang17
Copy link
Contributor

@xiang17 xiang17 commented Jun 8, 2022

Fixes #383.

Changes

  • For gc.fragmentation.ratio, use ObservableGauge and change value from percentage to fraction in range of [0, 1]
  • Rename alloc.rate to gc.allocated.bytes
  • Updates units to use Bytes for data volume; use nanoseconds in Int64 rather than seconds or milliseconds in Double
  • gc.committed: use ObservableGauge
  • Update all value types from Int32 to Int64

For significant contributions please make sure you have completed the following items:

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #409 (e3ae6a2) into main (768d94b) will not change coverage.
The diff coverage is 0.00%.

❗ Current head e3ae6a2 differs from pull request most recent head 50002c4. Consider uploading reports for the commit 50002c4 to get more accurate results

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #409   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files        155     155           
  Lines       4776    4776           
=====================================
  Misses      4776    4776           
Impacted Files Coverage Δ
...elemetry.Instrumentation.Runtime/RuntimeMetrics.cs 0.00% <0.00%> (ø)

@xiang17 xiang17 changed the title Fix existing bugs in Runtime metrics Fix some bugs in Runtime metrics Jun 8, 2022
@xiang17 xiang17 marked this pull request as ready for review June 8, 2022 21:14
@xiang17 xiang17 requested a review from a team June 8, 2022 21:14
@utpilla utpilla merged commit 5ac01fa into open-telemetry:main Jun 10, 2022
swetharavichandrancisco pushed a commit to swetharavichandrancisco/opentelemetry-dotnet-contrib that referenced this pull request Jun 16, 2022
* Update instrument types, value types and units and some renames
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NewRelic metric errors (monotonic values must be positive)
4 participants