Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Instrumentation.Runtime] Amend CHANGELOG.md for 1.0.0-rc.2 #523

Merged
merged 3 commits into from
Jul 21, 2022
Merged

[Instrumentation.Runtime] Amend CHANGELOG.md for 1.0.0-rc.2 #523

merged 3 commits into from
Jul 21, 2022

Conversation

xiang17
Copy link
Contributor

@xiang17 xiang17 commented Jul 21, 2022

Changes

#475 included some breaking changes in metrics names and descriptions. There should have been an entry for this in the CHANGELOG.md.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #

@xiang17 xiang17 requested a review from a team July 21, 2022 00:04
@xiang17 xiang17 changed the title Amend CHANGELOG.md for 1.0.0-rc.2 [Instrumentation.Runtime] Amend CHANGELOG.md for 1.0.0-rc.2 Jul 21, 2022
@utpilla utpilla added the comp:instrumentation.runtime Things related to OpenTelemetry.Instrumentation.Runtime label Jul 21, 2022
@cijothomas cijothomas merged commit 6fcb78e into open-telemetry:main Jul 21, 2022
@xiang17 xiang17 deleted the xiang17/updateChangelog branch July 21, 2022 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cijothomas cijothomas cijothomas approved these changes

@Kielek Kielek Kielek approved these changes

Assignees

@xiang17 xiang17

Labels
comp:instrumentation.runtime Things related to OpenTelemetry.Instrumentation.Runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiang17 @cijothomas @Kielek @utpilla