Skip to content

Commit

Permalink
Remove RentrantExportProcessor as it is not required by spec (#1496)
Browse files Browse the repository at this point in the history 
* Remove RentrantExportProcessor as it is not required by spec

* clean up api doc

* fix doc

* remove deadlinks

* remove test

* more removals
  • Loading branch information
@cijothomas
cijothomas committed Nov 10, 2020
1 parent 32a500c commit 8775969
Show file tree
Hide file tree
Showing 9 changed files with 1 addition and 153 deletions.
1 change: 0 additions & 1 deletion docs/logs/extending-the-sdk/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ OpenTelemetry .NET SDK has provided the following built-in processors:

* [BatchExportProcessor<T>](../../../src/OpenTelemetry/BatchExportProcessor.cs)
* [CompositeProcessor<T>](../../../src/OpenTelemetry/CompositeProcessor.cs)
* [ReentrantExportProcessor<T>](../../../src/OpenTelemetry/ReentrantExportProcessor.cs)
* [SimpleExportProcessor<T>](../../../src/OpenTelemetry/SimpleExportProcessor.cs)

Custom processors can be implemented to cover more scenarios:
Expand Down
1 change: 0 additions & 1 deletion docs/trace/extending-the-sdk/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ OpenTelemetry .NET SDK has provided the following built-in processors:

* [BatchExportProcessor<T>](../../../src/OpenTelemetry/BatchExportProcessor.cs)
* [CompositeProcessor<T>](../../../src/OpenTelemetry/CompositeProcessor.cs)
* [ReentrantExportProcessor<T>](../../../src/OpenTelemetry/ReentrantExportProcessor.cs)
* [SimpleExportProcessor<T>](../../../src/OpenTelemetry/SimpleExportProcessor.cs)

Custom processors can be implemented to cover more scenarios:
Expand Down
3 changes: 0 additions & 3 deletions src/OpenTelemetry/.publicApi/net452/PublicAPI.Unshipped.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,6 @@ OpenTelemetry.Metrics.MeterProviderBuilder.SetExporter(OpenTelemetry.Metrics.Exp
OpenTelemetry.Metrics.MeterProviderBuilder.SetProcessor(OpenTelemetry.Metrics.Export.MetricProcessor processor) -> OpenTelemetry.Metrics.MeterProviderBuilder
OpenTelemetry.Metrics.MeterProviderBuilder.SetPushInterval(System.TimeSpan pushInterval) -> OpenTelemetry.Metrics.MeterProviderBuilder
OpenTelemetry.ProviderExtensions
OpenTelemetry.ReentrantExportProcessor<T>
OpenTelemetry.ReentrantExportProcessor<T>.ReentrantExportProcessor(OpenTelemetry.BaseExporter<T> exporter) -> void
OpenTelemetry.Resources.Resource
OpenTelemetry.Resources.Resource.Attributes.get -> System.Collections.Generic.IEnumerable<System.Collections.Generic.KeyValuePair<string, object>>
OpenTelemetry.Resources.Resource.Merge(OpenTelemetry.Resources.Resource other) -> OpenTelemetry.Resources.Resource
Expand Down Expand Up @@ -213,7 +211,6 @@ override OpenTelemetry.Metrics.Aggregators.Int64MeasureMinMaxSumCountAggregator.
override OpenTelemetry.Metrics.Aggregators.Int64MeasureMinMaxSumCountAggregator.Update(long value) -> void
override OpenTelemetry.Metrics.Export.UngroupedBatcher.FinishCollectionCycle(out System.Collections.Generic.IEnumerable<OpenTelemetry.Metrics.Export.Metric> metrics) -> void
override OpenTelemetry.Metrics.Export.UngroupedBatcher.Process(OpenTelemetry.Metrics.Export.Metric metric) -> void
override OpenTelemetry.ReentrantExportProcessor<T>.OnEnd(T data) -> void
override OpenTelemetry.SimpleExportProcessor<T>.OnEnd(T data) -> void
override OpenTelemetry.Trace.AlwaysOffSampler.ShouldSample(in OpenTelemetry.Trace.SamplingParameters samplingParameters) -> OpenTelemetry.Trace.SamplingResult
override OpenTelemetry.Trace.AlwaysOnSampler.ShouldSample(in OpenTelemetry.Trace.SamplingParameters samplingParameters) -> OpenTelemetry.Trace.SamplingResult
Expand Down
3 changes: 0 additions & 3 deletions src/OpenTelemetry/.publicApi/net46/PublicAPI.Unshipped.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,6 @@ OpenTelemetry.Metrics.MeterProviderBuilder.SetExporter(OpenTelemetry.Metrics.Exp
OpenTelemetry.Metrics.MeterProviderBuilder.SetProcessor(OpenTelemetry.Metrics.Export.MetricProcessor processor) -> OpenTelemetry.Metrics.MeterProviderBuilder
OpenTelemetry.Metrics.MeterProviderBuilder.SetPushInterval(System.TimeSpan pushInterval) -> OpenTelemetry.Metrics.MeterProviderBuilder
OpenTelemetry.ProviderExtensions
OpenTelemetry.ReentrantExportProcessor<T>
OpenTelemetry.ReentrantExportProcessor<T>.ReentrantExportProcessor(OpenTelemetry.BaseExporter<T> exporter) -> void
OpenTelemetry.Resources.Resource
OpenTelemetry.Resources.Resource.Attributes.get -> System.Collections.Generic.IEnumerable<System.Collections.Generic.KeyValuePair<string, object>>
OpenTelemetry.Resources.Resource.Merge(OpenTelemetry.Resources.Resource other) -> OpenTelemetry.Resources.Resource
Expand Down Expand Up @@ -213,7 +211,6 @@ override OpenTelemetry.Metrics.Aggregators.Int64MeasureMinMaxSumCountAggregator.
override OpenTelemetry.Metrics.Aggregators.Int64MeasureMinMaxSumCountAggregator.Update(long value) -> void
override OpenTelemetry.Metrics.Export.UngroupedBatcher.FinishCollectionCycle(out System.Collections.Generic.IEnumerable<OpenTelemetry.Metrics.Export.Metric> metrics) -> void
override OpenTelemetry.Metrics.Export.UngroupedBatcher.Process(OpenTelemetry.Metrics.Export.Metric metric) -> void
override OpenTelemetry.ReentrantExportProcessor<T>.OnEnd(T data) -> void
override OpenTelemetry.SimpleExportProcessor<T>.OnEnd(T data) -> void
override OpenTelemetry.Trace.AlwaysOffSampler.ShouldSample(in OpenTelemetry.Trace.SamplingParameters samplingParameters) -> OpenTelemetry.Trace.SamplingResult
override OpenTelemetry.Trace.AlwaysOnSampler.ShouldSample(in OpenTelemetry.Trace.SamplingParameters samplingParameters) -> OpenTelemetry.Trace.SamplingResult
Expand Down
3 changes: 0 additions & 3 deletions src/OpenTelemetry/.publicApi/net461/PublicAPI.Unshipped.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,6 @@ OpenTelemetry.Metrics.MeterProviderBuilder.SetExporter(OpenTelemetry.Metrics.Exp
OpenTelemetry.Metrics.MeterProviderBuilder.SetProcessor(OpenTelemetry.Metrics.Export.MetricProcessor processor) -> OpenTelemetry.Metrics.MeterProviderBuilder
OpenTelemetry.Metrics.MeterProviderBuilder.SetPushInterval(System.TimeSpan pushInterval) -> OpenTelemetry.Metrics.MeterProviderBuilder
OpenTelemetry.ProviderExtensions
OpenTelemetry.ReentrantExportProcessor<T>
OpenTelemetry.ReentrantExportProcessor<T>.ReentrantExportProcessor(OpenTelemetry.BaseExporter<T> exporter) -> void
OpenTelemetry.Resources.Resource
OpenTelemetry.Resources.Resource.Attributes.get -> System.Collections.Generic.IEnumerable<System.Collections.Generic.KeyValuePair<string, object>>
OpenTelemetry.Resources.Resource.Merge(OpenTelemetry.Resources.Resource other) -> OpenTelemetry.Resources.Resource
Expand Down Expand Up @@ -232,7 +230,6 @@ override OpenTelemetry.Metrics.Aggregators.Int64MeasureMinMaxSumCountAggregator.
override OpenTelemetry.Metrics.Aggregators.Int64MeasureMinMaxSumCountAggregator.Update(long value) -> void
override OpenTelemetry.Metrics.Export.UngroupedBatcher.FinishCollectionCycle(out System.Collections.Generic.IEnumerable<OpenTelemetry.Metrics.Export.Metric> metrics) -> void
override OpenTelemetry.Metrics.Export.UngroupedBatcher.Process(OpenTelemetry.Metrics.Export.Metric metric) -> void
override OpenTelemetry.ReentrantExportProcessor<T>.OnEnd(T data) -> void
override OpenTelemetry.SimpleExportProcessor<T>.OnEnd(T data) -> void
override OpenTelemetry.Trace.AlwaysOffSampler.ShouldSample(in OpenTelemetry.Trace.SamplingParameters samplingParameters) -> OpenTelemetry.Trace.SamplingResult
override OpenTelemetry.Trace.AlwaysOnSampler.ShouldSample(in OpenTelemetry.Trace.SamplingParameters samplingParameters) -> OpenTelemetry.Trace.SamplingResult
Expand Down
3 changes: 0 additions & 3 deletions src/OpenTelemetry/.publicApi/netstandard2.0/PublicAPI.Unshipped.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,6 @@ OpenTelemetry.Metrics.MeterProviderBuilder.SetExporter(OpenTelemetry.Metrics.Exp
OpenTelemetry.Metrics.MeterProviderBuilder.SetProcessor(OpenTelemetry.Metrics.Export.MetricProcessor processor) -> OpenTelemetry.Metrics.MeterProviderBuilder
OpenTelemetry.Metrics.MeterProviderBuilder.SetPushInterval(System.TimeSpan pushInterval) -> OpenTelemetry.Metrics.MeterProviderBuilder
OpenTelemetry.ProviderExtensions
OpenTelemetry.ReentrantExportProcessor<T>
OpenTelemetry.ReentrantExportProcessor<T>.ReentrantExportProcessor(OpenTelemetry.BaseExporter<T> exporter) -> void
OpenTelemetry.Resources.Resource
OpenTelemetry.Resources.Resource.Attributes.get -> System.Collections.Generic.IEnumerable<System.Collections.Generic.KeyValuePair<string, object>>
OpenTelemetry.Resources.Resource.Merge(OpenTelemetry.Resources.Resource other) -> OpenTelemetry.Resources.Resource
Expand Down Expand Up @@ -232,7 +230,6 @@ override OpenTelemetry.Metrics.Aggregators.Int64MeasureMinMaxSumCountAggregator.
override OpenTelemetry.Metrics.Aggregators.Int64MeasureMinMaxSumCountAggregator.Update(long value) -> void
override OpenTelemetry.Metrics.Export.UngroupedBatcher.FinishCollectionCycle(out System.Collections.Generic.IEnumerable<OpenTelemetry.Metrics.Export.Metric> metrics) -> void
override OpenTelemetry.Metrics.Export.UngroupedBatcher.Process(OpenTelemetry.Metrics.Export.Metric metric) -> void
override OpenTelemetry.ReentrantExportProcessor<T>.OnEnd(T data) -> void
override OpenTelemetry.SimpleExportProcessor<T>.OnEnd(T data) -> void
override OpenTelemetry.Trace.AlwaysOffSampler.ShouldSample(in OpenTelemetry.Trace.SamplingParameters samplingParameters) -> OpenTelemetry.Trace.SamplingResult
override OpenTelemetry.Trace.AlwaysOnSampler.ShouldSample(in OpenTelemetry.Trace.SamplingParameters samplingParameters) -> OpenTelemetry.Trace.SamplingResult
Expand Down
1 change: 1 addition & 0 deletions src/OpenTelemetry/CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
* `Resource` is no longer added to observed `Activity` objects as a
`CustomProperty`.
([#1463](https://github.com/open-telemetry/opentelemetry-dotnet/pull/1463))
* Remove RentrantExportProcessor as it is not required by spec.

## 0.8.0-beta.1

Expand Down
51 changes: 0 additions & 51 deletions src/OpenTelemetry/ReentrantExportProcessor.cs
View file

This file was deleted.

88 changes: 0 additions & 88 deletions test/OpenTelemetry.Tests/Trace/ReentrantExportActivityProcessorTest.cs
View file

This file was deleted.

0 comments on commit 8775969

Please sign in to comment.