Add support for regex #1023
Closed
Add support for regex #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1023 +/- ##
==========================================
- Coverage 75.52% 75.38% -0.14%
==========================================
Files 222 221 -1
Lines 6210 6221 +11
==========================================
Hits 4690 4690
- Misses 1520 1531 +11
|
CodeBlanch
reviewed
Aug 9, 2020
|
|
||
| foreach (var name in sources) | ||
| { | ||
| activitySources[name] = true; | ||
| if (string.IsNullOrWhiteSpace(name)) |
There was a problem hiding this comment.
@cijothomas Do we still need to listen to the blank source for the legacy Activity objects? Or did the ActivitySourceAdapter take care of that?
|
Superseded by #1032. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows folks to use (and later will be available in builder pattern
AddActivitySource("MyCompany.MyProduct.*")):I didn't add test cases/examples/tutorial, will add it after the API got cleaned up (otherwise we'll waste energy changing them back and force).